Uh oh!
There was an error while loading. Please reload this page.
chore: fix security issues + release - #2977
Open
Sruthisreem wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
darekplawecki
left a comment
Contributor
There was a problem hiding this comment.
To release the changes, you have to bump the versions in corresponding package.json files just like here.
| "piscina": "^4.9.3", | ||
| "webpack-dev-middleware": "^5.3.4" | ||
| "webpack-dev-middleware": "^5.3.4", | ||
| "pacote": "^21.5.1" |
Contributor
There was a problem hiding this comment.
Are u sure this huge major upgrade won't break anything? Would be good to double check with Claude. Also, the angular example is used to run E2E tests in the release pipeline, but you can run it locally and verify.
This applies also to other major upgrades (serialize-javascript, bfj).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.