Uh oh!
There was an error while loading. Please reload this page.
feat(request-maker): use upstream httpsnippet - #663
Conversation
Deploy preview for stoplight-elements ready! Built with commit e3611f3 |
mallachari
left a comment
There was a problem hiding this comment.
Works good!
There are TS problems regarding importing modules. Check out test step.
marcelltoth
commented
Oct 28, 2020
I'm aware. There are some DefinitelyTyped issues: DefinitelyTyped/DefinitelyTyped#49170 Also we make quite a lot of lies in the |
| name: p.name, | ||
| fileName: p.name, | ||
| value: p.value, | ||
| value: p.value instanceof File ? '<file contents>' : p.value, |
There was a problem hiding this comment.
These are intentionally dummy. I wanted to make the least intrusive change possible while correcting the type violations.
mallachari
left a comment
There was a problem hiding this comment.
Still good to me 👍
There's some build error but it looks irrelevant. Locally works fine.
mallachari
commented
Oct 30, 2020
Oh, the tests are failing. I think you forgot to add new snippet data |
marcelltoth
commented
Nov 2, 2020
Tests fixed. Unfortunately it looks like the build cannot be fixed just yet. Iceboxing this until the upstream issue is resolved |
fae2d87 to
3713abbComparemarcelltoth
commented
Nov 19, 2020
I convinced Kong to release a new version 🎉 😇 So this is good to go. Rebased. |
Resolves#628
Depends on DefinitelyTyped/DefinitelyTyped#48987
After merging this PR we should archive stoplightio/httpsnippet