Fix thrust namespace for CUDA 12.6 - #428
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 32 32
Lines 2524 2524
=======================================
Hits 2457 2457
Misses 67 67 ☔ View full report in Codecov by Sentry. |
Owner
|
Thanks for working on a fix for CUDA 12.6. For reference, the respective namespace macros were introduced in thrust 1.13.1 and CUDA 11.5. We technically also support older CUDA version down to 11.0, so a fallback would actually be needed for those. However, I do not believe that such old versions are still in use, so just bumping the minimum requirements should be sufficient. I will handle the respective documentation changes. Other than that, LGTM. Thanks again for the contribution! |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affecting compilation issue mentioned here: #417 (comment). The other device-code compilation errors with CUDA 12.5 mentioned in the issue are not adressed with this PR.
Thrust changed the namespace for its implementations from
thrust::tothrust::<<ABI_IDENTIFIER>>::since thrust 2.3.0.For the few template specializations in iterator_impl, its necessary to to use the correct namespaces. Using the
THRUST_NAMESPACE_BEGIN/ENDmarcos should make sure that we always use the correct namespace, even with older CUDA Toolkit versions, but I did not exhaustively test that.