Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (7)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
🟡 Changes recommended
Multiple workflows mint GitHub App tokens using client-id wired to *_APP_ID secrets (App ID vs client ID mismatch), which is likely to break token generation across automation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR syncs a large set of workflow templates, scripts, and documentation from stranske/Workflows into this consumer repository, updating the automation surface (agents, keepalive, coverage guard, docs drift fixes) and aligning local docs/contracts with the upstream fleet standards.
Changes:
- Update GitHub Actions workflows to the latest consolidated “agents” topology and tightened API-client secret handling.
- Improve coverage reporting/guard rails (
coverage_trend.py,coverage_guard.py) including baseline semantics and contamination detection. - Add/extend backplane contract tooling and docs drift automation (tracked-variable schema + validator support, docs drift checker workflow).
File summaries
| File | Description |
|---|---|
| WORKFLOW_USER_GUIDE.md | Updates user-facing workflow behavior docs (ready PRs, event hub naming, new recovery procedures). |
| tools/coverage_trend.py | Makes baseline handling explicit (no silent 0.0), adds project-root contamination filtering and richer summaries/outputs. |
| tools/coverage_guard.py | Adds warn-drop breach semantics and improved recovery messaging/threshold logic. |
| scripts/validate_run_contract.py | Adds tracked-variable schema validation mode and schema registry handling for tracked-variable refs. |
| scripts/sync_test_dependencies.py | Updates canonical base module set and broadens local module detection behavior. |
| scripts/langchain/progress_reviewer.py | Always emits a structured review payload derived from analysis fields. |
| scripts/langchain/label_matcher.py | Refines keyword matching with explicit aliases, adds diverse match selection and safer auto-apply logic. |
| scripts/langchain/capability_check.py | Removes deprecated alias export to align callers with classify_capabilities. |
| scripts/check_docs_drift.py | Adds a deterministic docs drift detector for workflow inventory + dangling inline path references. |
| scripts/check_deliberate_break.py | Improves fallback test-name extraction and prioritizes explicit markers anywhere in PR body. |
| docs/contracts/tracked-variable-v1.md | Adds normative spec doc for tracked-variable/v1 contract and validation instructions. |
| docs/contracts/schemas/tracked-variable-v1.schema.json | Introduces tracked-variable v1 JSON schema referencing embedded evidence schema. |
| docs/contracts/agent-runner-output.md | Bumps contract to v1.2; adds optional subject-id output documentation. |
| docs/CI_SYSTEM_GUIDE.md | Updates system guide to current consumer entry points and guarded delivery behavior. |
| config/source_of_truth_docs.yml | Adds consumer-local source-of-truth doc list for docs-drift agent. |
| config/model_registry.json | Updates model source references and pricing metadata. |
| CLAUDE.md | Adds “Pull Request Readiness Invariant” guidance for automation-created PRs. |
| AGENTS.md | Adds “Pull Request Readiness Invariant” guidance for automation-created PRs. |
| .gitignore | Appends managed Workflows status-file ignore block to avoid automation artifacts being committed. |
| .github/workflows/reusable-pr-context.yml | Updates reusable PR-context workflow including App-token minting wiring. |
| .github/workflows/maint-coverage-guard.yml | Updates coverage guard workflow (artifact discovery, source workflow configurability, clearer outcomes). |
| .github/workflows/maint-87-docs-drift-fix-agent.yml | Adds weekly docs drift planning workflow with dispatch-only issue creation. |
| .github/workflows/maint-76-claude-code-review.yml | Updates API client setup inputs and bumps Claude action pin. |
| .github/workflows/backplane-conformance.yml | Guards editable installs for non-packaged consumer repos. |
| .github/workflows/agents-weekly-metrics.yml | Updates token minting + API client setup and improves tracker body stamping. |
| .github/workflows/agents-verify-to-new-pr.yml | Updates API client setup to pass named secret inputs (removes whole-secrets blob). |
| .github/workflows/agents-verifier.yml | Updates API client setup to pass named secret inputs (removes whole-secrets blob). |
| .github/workflows/agents-keepalive-sweep.yml | Splits consolidated vs non-consolidated sweep modes; tightens eligibility label requirements. |
| .github/workflows/agents-keepalive-loop-reporter.yml | Updates reporter token minting and safety checks for failure reporting. |
| .github/workflows/agents-issue-optimizer.yml | Tightens recursion pause logic, improves failure comments, updates token minting + named secret inputs. |
| .github/workflows/agents-issue-intake.yml | Removes draft-PR bootstrap toggle to enforce ready-for-review invariant. |
| .github/workflows/agents-issue-format-guard.yml | Expands triggers, adds stale lease cleanup, and updates exemption/hold logic. |
| .github/workflows/agents-guard.yml | Updates API client setup inputs; bumps fallback action pin. |
| .github/workflows/agents-dedup.yml | Guards dependency install for non-packaged repos; updates API client setup inputs. |
| .github/workflows/agents-decompose.yml | Guards dependency install for non-packaged repos; updates API client setup inputs. |
| .github/workflows/agents-capability-check.yml | Guards dependency install for non-packaged repos; updates caller import to classify_capabilities. |
| .github/workflows/agents-autofix-dispatcher.yml | Updates token minting + named secret inputs. |
| .github/workflows/agents-auto-pilot.yml | Updates token minting + named secret inputs; removes legacy workflow fallbacks for consolidated mode. |
| .github/workflows/agents-auto-label.yml | Updates dependency install fallback; adopts new matcher auto-apply logic. |
| .github/workflows/agents-80-pr-event-hub.yml | Tightens bot-comment handler follow-up gating and updates API client setup inputs. |
| .github/workflows/agents-73-codex-belt-conveyor.yml | Updates token minting + named secret inputs. |
| .github/workflows/agents-72-codex-belt-worker.yml | Updates token minting + named secret inputs (including belt-tools path). |
| .github/workflows/agents-71-codex-belt-dispatcher.yml | Refactors helper checkout/staging and adds rate-limit preflight gating. |
| .github/scripts/token_load_balancer.js | Adds explicit statuses capability handling and correct aliasing for statuses:write. |
| .github/scripts/sync_tracker_state/index.js | Adds durable/transient tracker support and tightens “open PR” detection to same-repo heads. |
| .github/scripts/source_context.js | Tightens issue-number inference to avoid ambiguity; adds “closing issue” extraction. |
| .github/scripts/keepalive_post_work.js | Adds injectable clock for polling and passes it through post-work flows. |
| .github/scripts/keepalive_loop.js | Expands PR-number resolution, adds delegation-source reporting, and skips when no runner exists for selected agent. |
| .github/scripts/issue_format.py | Improves task/acceptance concrete-target detection and lint-command recognition; better error previews. |
| .github/scripts/github-api-with-retry.js | Adds rate-limit incident logging, stronger rate-limit preflight semantics, and clearer status-permission diagnostics. |
| .github/scripts/bot-comment-handler.js | Adds active-thread collection, payload bounding, and multi-part controller comment generation. |
| .github/scripts/agents_orchestrator_resolve.js | Forces draft_pr false to enforce ready-for-review PR creation. |
| .github/scripts/agent_delegation_policy.js | Adds route-weights support, round-kind mapping, runner eligibility checks, and delegation-source surfacing. |
Review details
- Files reviewed: 56/57 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| client-id: ${{ env.KEEPALIVE_APP_ID }} | ||
| private-key: ${{ env.KEEPALIVE_APP_PRIVATE_KEY }} |
| continue-on-error: true | ||
| with: | ||
| app-id: ${{ secrets.WORKFLOWS_APP_ID || '0' }} | ||
| client-id: ${{ secrets.WORKFLOWS_APP_ID || '0' }} |
| uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3 | ||
| with: | ||
| app-id: ${{ secrets.WORKFLOWS_APP_ID }} | ||
| client-id: ${{ secrets.WORKFLOWS_APP_ID }} |
27d597e to
5c78c09
Compare
5c78c09 to
be111e7
Compare
804aa0b to
bd4f69c
Compare
Automated sync from stranske/Workflows Template hash: 1f3f4541b9df Changes synced from sync-manifest.yml Consumer-sync plan ID: sha256:1f3f4541b9df343e4661e6b4b22ff90043955c6d9382b82eb3fbd4a96fa25c0c Plan scope: full Scope base SHA: full Source commit: 5ef1f72907e90b6a838a10b68ac047455ebd3914 Canary evidence JSON (base64): eyJzY2hlbWEiOiJ3b3JrZmxvd3MuY29uc3VtZXItc3luYy1jYW5hcnktZXZpZGVuY2UvdjEiLCJ2ZXJzaW9uIjoxLCJyZXN1bHRzIjpbeyJyZXBvIjoic3RyYW5za2UvVHJhdmVsLVBsYW4tUGVybWlzc2lvbiIsInBsYW5faWQiOiJzaGEyNTY6MWYzZjQ1NDFiOWRmMzQzZTQ2NjFlNmI0YjIyZmY5MDA0Mzk1NWM2ZDkzODJiODJlYjNmYmQ0YTk2ZmEyNWMwYyIsInBsYW5fc2NvcGUiOiJmdWxsIiwic2NvcGVfYmFzZV9zaGEiOiIiLCJzb3VyY2VfY29tbWl0IjoiNWVmMWY3MjkwN2U5MGI2YTgzOGExMGI2OGFjMDQ3NDU1ZWJkMzkxNCIsInByIjoxNTgyLCJoZWFkX3NoYSI6IjgzMzZjOGI5NGI5ZDVjY2ZiMmNlZWQ0ZWY0MjkyMjMxNzZhZDRhMzYiLCJldmlkZW5jZV9zb3VyY2UiOiJvcGVuLWNhbmRpZGF0ZSIsInJlcXVpcmVkX2NoZWNrX3N0YXRlIjoic3VjY2VzcyIsImFjdGl2ZV9yZXZpZXdfdGhyZWFkX2NvdW50IjowfSx7InJlcG8iOiJzdHJhbnNrZS90cmlwLXBsYW5uZXIiLCJwbGFuX2lkIjoic2hhMjU2OjFmM2Y0NTQxYjlkZjM0M2U0NjYxZTZiNGIyMmZmOTAwNDM5NTVjNmQ5MzgyYjgyZWIzZmJkNGE5NmZhMjVjMGMiLCJwbGFuX3Njb3BlIjoiZnVsbCIsInNjb3BlX2Jhc2Vfc2hhIjoiIiwic291cmNlX2NvbW1pdCI6IjVlZjFmNzI5MDdlOTBiNmE4MzhhMTBiNjhhYzA0NzQ1NWViZDM5MTQiLCJwciI6MTgyMSwiaGVhZF9zaGEiOiI5Y2EwOGQwNzkyNzgxYjk0OTUxNjkyYzhlNWYwMzc5NjFmNTI5Yjk1IiwiZXZpZGVuY2Vfc291cmNlIjoib3Blbi1jYW5kaWRhdGUiLCJyZXF1aXJlZF9jaGVja19zdGF0ZSI6InN1Y2Nlc3MiLCJhY3RpdmVfcmV2aWV3X3RocmVhZF9jb3VudCI6MH0seyJyZXBvIjoic3RyYW5za2UvUG9ydGFibGUtQWxwaGEtRXh0ZW5zaW9uLU1vZGVsIiwicGxhbl9pZCI6InNoYTI1NjoxZjNmNDU0MWI5ZGYzNDNlNDY2MWU2YjRiMjJmZjkwMDQzOTU1YzZkOTM4MmI4MmViM2ZiZDRhOTZmYTI1YzBjIiwicGxhbl9zY29wZSI6ImZ1bGwiLCJzY29wZV9iYXNlX3NoYSI6IiIsInNvdXJjZV9jb21taXQiOiI1ZWYxZjcyOTA3ZTkwYjZhODM4YTEwYjY4YWMwNDc0NTVlYmQzOTE0IiwicHIiOjIyOTksImhlYWRfc2hhIjoiYWNhYmUwMWQxYjUyZTFlYjcxZjgwZmY3MDk1ZjM4OTQ4NTFjZTljMiIsImV2aWRlbmNlX3NvdXJjZSI6Im9wZW4tY2FuZGlkYXRlIiwicmVxdWlyZWRfY2hlY2tfc3RhdGUiOiJzdWNjZXNzIiwiYWN0aXZlX3Jldmlld190aHJlYWRfY291bnQiOjB9XX0=
bd4f69c to
2d14571
Compare
Sync Summary
Files Updated
Files Skipped
Review Checklist
Source: stranske/Workflows
Source SHA:
5ef1f72907e90b6a838a10b68ac047455ebd3914Template hash:
1f3f4541b9dfConsumer-sync plan ID:
sha256:1f3f4541b9df343e4661e6b4b22ff90043955c6d9382b82eb3fbd4a96fa25c0cPlan scope:
fullScope base SHA:
fullSync phase:
promoteSync branch:
sync/workflows-deliveryConsumer repo:
stranske/Collab-AdminManifest:
.github/sync-manifest.ymlautofix: false