[P1] Consultant section ontology aligned to tracked-variable/v1 (B2-010)

[stranske]

Why

Consultant report sections need fleet ontology_key values aligned to B2-003. Verified: docs/contracts/standard_element_library.md:12 requires bundled _stub.json keep non_authoritative: true; src/inv_man_intake/intake/standard_elements.py:1-30 loads stub only with no consultant section keys.

Scope

Extend stub data with report.consultant_review element keys mapping to consultant.* ontology keys; conformance tests.

Non-Goals

• Do NOT set non_authoritative: false on bundled stub without external library.
• Do NOT emit tracked-variable/v1 yet (B2-017).
• Scaffold-only completion does NOT count.

Tasks

• Add data/consultant_sections.json with ≥15 section keys per R2 brief.
• Extend standard_elements.py to load consultant sections when doc_type is report.consultant_review.
• Add tests/intake/test_consultant_section_ontology.py.
• Map keys in README cross-reference to Workflows tracked-variable/v1 (after sync).

Acceptance Criteria

• Named test: tests/intake/test_consultant_section_ontology.py::test_sections_resolve_without_code_change passes (data-only add).
• Deliberate-break gate: remove one key from JSON → test must FAIL → revert.

Surfaced by B2-010; depends on Workflows B2-003.

[agents-workflows-bot]

🤖 Auto-pilot step $((STEP_COUNT + 1)): Starting issue formatting...

Running formatter inline (not via label trigger).

[stranske-keepalive]

🤖 Auto-pilot step $((STEP_COUNT + 1)): Analyzing issue for improvements...

Running optimizer inline (not via label trigger).

[stranske-keepalive]

Issue Optimization Suggestions

Review the suggestions below. If you want the agent to apply them, add the
agents:apply-suggestions label to this issue.

Task splitting

• Add tests/intake/test_consultant_section_ontology.py with test_sections_resolve_without_code_change, verifying every required consultant section key resolves to its expected consultant.* ontology key from data/consultant_sections.json; ensure the test passes with complete data and fails if a required key is removed. (This task combines test file creation, test implementation, verification logic, and failure mode testing. It's too broad for a single atomic task.). Suggested split: Create the test file tests/intake/test_consultant_section_ontology.py with appropriate imports and test structure, Implement test_sections_resolve_without_code_change to load consultant sections from the JSON data file, Add assertions that verify each section key resolves to its expected consultant ontology key, Verify the test passes when all required keys are present in the data file, Verify the test fails when any required key is removed from the data file.

Blocked tasks

• None

Objective acceptance criteria

• Add data/consultant_sections.json with ≥15 section keys per R2 brief. (The reference to 'R2 brief' is external and may not be accessible to the agent. The specific section keys required are not defined in the issue. | Either include the list of required section keys in the issue, provide a link to the R2 brief document, or specify the exact format and required fields for each section key entry (e.g., 'Each entry must have fields: key, ontology_key, description').)
• Update the README cross-reference to map keys to Workflows tracked-variable/v1 after sync. (The term 'after sync' is vague and the specific format/location for the cross-reference mapping is not defined. | Specify the exact section in the README where the mapping should be added, provide an example of the expected format, and clarify what 'after sync' means (e.g., 'Add a table in README.md section 3.2 mapping each consultant section key to its corresponding tracked-variable/v1 workflow identifier').)

Missing sections

• None

Formatting issues

• The 'Implementation Notes' section uses a semicolon-separated list format ('Surfaced by B2-010; depends on Workflows B2-003') instead of proper bullet points or sentences, which reduces readability.
• The third task bullet contains a very long run-on sentence with multiple semicolons that should be split into separate sub-bullets or a clearer structure.
• The acceptance criteria section mixes test execution requirements with a 'deliberate-break gate' pattern that could be formatted as a nested checklist for clarity.

Notes

• This issue is well-structured with all required sections present (Why, Scope, Non-Goals, Tasks, Acceptance Criteria, Implementation Notes). The agent should be able to complete most tasks, though the reference to 'R2 brief' may require clarification. The main issues are: (1) one task is too broad and should be split into 5 sub-tasks, (2) two acceptance criteria need more objective specifications, and (3) minor formatting improvements would enhance readability. The issue correctly avoids agent limitations (no workflow modifications, no subjective design decisions). The 'deliberate-break gate' pattern in acceptance criteria is actually a good practice for ensuring test robustness.

[agents-workflows-bot]

⚠️ Workflow failed

The agents-issue-optimizer workflow encountered an error.

Details: View workflow run

[agents-workflows-bot]

🤖 Auto-pilot step $((STEP_COUNT + 1)): Applying optimization suggestions...

Running apply inline (not via label trigger).

[github-actions]

This issue is not yet agent-processable. See docs/AGENT_ISSUE_FORMAT.md.

• Tasks item must name a concrete file, symbol, path, config key, job, or command: Add assertions that verify each section key resolves to its expected consultant ontology key.

Advisory:

• 5 cited path(s) do not exist yet: _stub.json, tracked-variable/v1, data/consultant_sections.json, standard_elements.py, tests/intake/test_consultant_section_ontology.py — expected when a task creates them; check for typos otherwise.

Dispatched the Agents Issue Optimizer format phase (attempt 1 of 3).

[stranske-keepalive]

🤖 Auto-pilot step 1: Issue prepared! Assigning to agent...

Adding agent:codex label. The capability check will run automatically.

⏳ Agent will create a PR shortly.

[stranske-keepalive]

⚠️ Capability Check: Some tasks may need human assistance

Recommendation: REVIEW_NEEDED

✅ Actionable Tasks (5):

• Add data/consultant_sections.json with ≥15 section keys per R2 brief.
• Extend standard_elements.py to load consultant sections when doc_type is report.consultant_review.
• Create the test file tests/intake/test_consultant_section_ontology.py with appropriate imports (verify: tests pass)
• Create the test file tests/intake/test_consultant_section_ontology.py with test structure (verify: tests pass)
• Update the README cross-reference to map keys to Workflows tracked-variable/v1 after sync.

⚠️ Partial Tasks (5):

• Add tests/intake/test_consultant_section_ontology.py with test_sections_resolve_without_code_change, verifying every required consultant section key resolves to its expected consultant.* ontology key from data/consultant_sections.json; ensure the test passes with complete data and fails if a required key is removed.
  • Limitation: Task bundles multiple actions; split into smaller tasks.
• Implement test_sections_resolve_without_code_change to load consultant sections from the JSON data file (verify: confirm completion in repo)
  • Limitation: Task bundles multiple actions; split into smaller tasks.
• Add assertions that verify each section key resolves to its expected consultant ontology key
  • Limitation: Task bundles multiple actions; split into smaller tasks.
• Verify the test passes when all required keys are present in the data file
  • Limitation: Task bundles multiple actions; split into smaller tasks.
• Verify the test fails when any required key is removed from the data file
  • Limitation: Task bundles multiple actions; split into smaller tasks.

👤 Human Actions Needed:

• Split task into smaller steps: Add tests/intake/test_consultant_section_ontology.py with test_sections_resolve_without_code_change, verifying every required consultant section key resolves to its expected consultant.* ontology key from data/consultant_sections.json; ensure the test passes with complete data and fails if a required key is removed.
• Split task into smaller steps: Implement test_sections_resolve_without_code_change to load consultant sections from the JSON data file (verify: confirm completion in repo)
• Split task into smaller steps: Add assertions that verify each section key resolves to its expected consultant ontology key
• Split task into smaller steps: Verify the test passes when all required keys are present in the data file
• Split task into smaller steps: Verify the test fails when any required key is removed from the data file
• LLM provider unavailable

---

Auto-generated by capability check