[P1] report-spec.json renderer contract (B2-031)

[stranske]

Why

OnePagerModel is renderer-oriented but no report-spec.json fleet profile exists. Verified: tests/export/test_one_pager.py:1-30 exercises one-pager export without any report-spec.json assertion, and grep -r report-spec src returns no matches. Missing behavior: no output-substrate profile emission. Depends on: Pension-Data B2-029 renderer-shell, Workflows B2-028.

Scope

Emit report-spec.json alongside one-pager exports referencing output-substrate profile.

Non-Goals

• Do NOT fork Pension-Data web app.
• Scaffold-only completion does NOT count.

Tasks

• Add src/inv_man_intake/export/report_spec.py.
• Wire into existing one-pager export path (tests/export/test_one_pager.py reference).
• Add tests/export/test_report_spec.py.

Acceptance Criteria

• Named test: tests/export/test_report_spec.py::test_report_spec_validates passes.
• Deliberate-break gate: remove renderer_profile → test must FAIL → revert.

Surfaced by B2-031.

[agents-workflows-bot]

🤖 Auto-pilot step $((STEP_COUNT + 1)): Starting issue formatting...

Running formatter inline (not via label trigger).

[agents-workflows-bot]

🤖 Auto-pilot step $((STEP_COUNT + 1)): Analyzing issue for improvements...

Running optimizer inline (not via label trigger).

[agents-workflows-bot]

Issue Optimization Suggestions

Review the suggestions below. If you want the agent to apply them, add the
agents:apply-suggestions label to this issue.

Task splitting

• Create src/inv_man_intake/export/report_spec.py defining the report-spec schema or builder with a required renderer_profile field, and verify it is importable by the one-pager export path. (This task combines schema definition, implementation, and integration verification. These are distinct steps that should be completed and verified separately.). Suggested split: Define the report-spec schema or builder class in src/inv_man_intake/export/report_spec.py with a required renderer_profile field, Add validation logic to ensure the renderer_profile field is present and non-empty in the schema, Import the report-spec module in the one-pager export path and verify no import errors occur.
• Wire report-spec.json emission into the existing one-pager export path referenced by tests/export/test_one_pager.py. (This task is vague about what 'wiring' means and doesn't specify the integration points or expected behavior.). Suggested split: Identify the export function in the one-pager export path that should emit the report-spec file, Add code to generate the report-spec JSON structure with the renderer_profile field populated, Write the report-spec JSON to a file named report-spec.json in the same directory as the one-pager export output.
• Add tests/export/test_report_spec.py with test_report_spec_validates, verifying emitted report-spec.json includes renderer_profile and validation fails when that field is removed. (This task combines test file creation, positive validation testing, and negative validation testing. These should be separate verifiable steps.). Suggested split: Create the test file tests/export/test_report_spec.py with necessary imports and test fixtures, Implement test_report_spec_validates to verify that emitted report-spec.json contains the renderer_profile field, Add assertions to verify that validation fails when the renderer_profile field is removed from the report-spec.

Blocked tasks

• None

Objective acceptance criteria

• Removing renderer_profile causes the validation test to fail; reverting restores the passing test. (This is a manual verification step that requires human intervention to remove code, run tests, and revert. The agent cannot perform deliberate code breakage and restoration as a test criterion. | Replace with: 'The test test_report_spec_validates includes a sub-test or assertion that explicitly validates a report-spec missing renderer_profile raises a validation error or returns False.' This makes it a programmatic test rather than a manual verification gate.)

Missing sections

• None

Formatting issues

• The 'Implementation Notes' section uses 'Depends on' language that could be clearer. Consider: 'This work requires completion of Pension-Data B2-029 (renderer-shell) and Workflows B2-028 before implementation can begin.'
• The 'Non-Goals' section uses inconsistent formatting: 'Do not fork' vs 'Scaffold-only completion does not count'. Consider parallel structure: 'Do not fork Pension-Data web app' and 'Do not accept scaffold-only completion without functional implementation.'

Notes

• This issue is well-structured with all required sections present. The main concerns are: (1) tasks that bundle multiple implementation steps together, making them harder to verify atomically; (2) an acceptance criterion that requires manual code-breaking rather than programmatic validation; (3) minor formatting inconsistencies. The issue provides good context with file paths and grep verification, making it actionable. The dependency tracking is clear. Consider splitting the broader tasks into more granular steps and converting the manual 'deliberate-break gate' into a programmatic negative test case.

[agents-workflows-bot]

⚠️ Workflow failed

The agents-issue-optimizer workflow encountered an error.

Details: View workflow run

[stranske-keepalive]

🤖 Auto-pilot step $((STEP_COUNT + 1)): Applying optimization suggestions...

Running apply inline (not via label trigger).

[github-actions]

This issue is not yet agent-processable. See docs/AGENT_ISSUE_FORMAT.md.

• Tasks item must name a concrete file, symbol, path, config key, job, or command: non-empty in the schema (verify: confirm completion in repo).

Advisory:

• 4 cited path(s) do not exist yet: report-spec.json, clones/Inv-Man-Intake/tests/export/test_one_pager.py, src/inv_man_intake/export/report_spec.py, tests/export/test_report_spec.py — expected when a task creates them; check for typos otherwise.

Dispatched the Agents Issue Optimizer format phase (attempt 1 of 3).

[stranske-keepalive]

🤖 Auto-pilot step 1: Issue prepared! Assigning to agent...

Adding agent:codex label. The capability check will run automatically.

⏳ Agent will create a PR shortly.

[stranske-keepalive]

⚠️ Capability Check: Some tasks may need human assistance

Recommendation: REVIEW_NEEDED

✅ Actionable Tasks (6):

• non-empty in the schema (verify: confirm completion in repo)
• verify no import errors occur
• Wire report-spec.json emission into the existing one-pager export path referenced by tests/export/test_one_pager.py.
• Create the test file tests/export/test_report_spec.py with necessary imports (verify: tests pass)
• Create the test file tests/export/test_report_spec.py with test fixtures (verify: tests pass)
• Implement test_report_spec_validates to verify that emitted report-spec.json contains the renderer_profile field

⚠️ Partial Tasks (9):

• Create src/inv_man_intake/export/report_spec.py defining the report-spec schema or builder with a required renderer_profile field, and verify it is importable by the one-pager export path.
  • Limitation: Task bundles multiple actions; split into smaller tasks.
• Define the report-spec schema or builder class in src/inv_man_intake/export/report_spec.py with a required renderer_profile field (verify: confirm completion in repo)
  • Limitation: Task bundles multiple actions; split into smaller tasks.
• Add validation logic to ensure the renderer_profile field is present (verify: confirm completion in repo)
  • Limitation: Task bundles multiple actions; split into smaller tasks.
• Import the report-spec module in the one-pager export path (verify: confirm completion in repo)
  • Limitation: Task bundles multiple actions; split into smaller tasks.
• Identify the export function in the one-pager export path that should emit the report-spec file (verify: confirm completion in repo)
  • Limitation: Task bundles multiple actions; split into smaller tasks.
• Add code to generate the report-spec JSON structure with the renderer_profile field populated (verify: confirm completion in repo)
  • Limitation: Task bundles multiple actions; split into smaller tasks.
• Write the report-spec JSON to a file named report-spec.json in the same directory as the one-pager export output (verify: confirm completion in repo)
  • Limitation: Task bundles multiple actions; split into smaller tasks.
• Add tests/export/test_report_spec.py with test_report_spec_validates, verifying emitted report-spec.json includes renderer_profile and validation fails when that field is removed.
  • Limitation: Task bundles multiple actions; split into smaller tasks.
• Add assertions to verify that validation fails when the renderer_profile field is removed from the report-spec
  • Limitation: Task bundles multiple actions; split into smaller tasks.

👤 Human Actions Needed:

• Split task into smaller steps: Create src/inv_man_intake/export/report_spec.py defining the report-spec schema or builder with a required renderer_profile field, and verify it is importable by the one-pager export path.
• Split task into smaller steps: Define the report-spec schema or builder class in src/inv_man_intake/export/report_spec.py with a required renderer_profile field (verify: confirm completion in repo)
• Split task into smaller steps: Add validation logic to ensure the renderer_profile field is present (verify: confirm completion in repo)
• Split task into smaller steps: Import the report-spec module in the one-pager export path (verify: confirm completion in repo)
• Split task into smaller steps: Identify the export function in the one-pager export path that should emit the report-spec file (verify: confirm completion in repo)
• Split task into smaller steps: Add code to generate the report-spec JSON structure with the renderer_profile field populated (verify: confirm completion in repo)
• Split task into smaller steps: Write the report-spec JSON to a file named report-spec.json in the same directory as the one-pager export output (verify: confirm completion in repo)
• Split task into smaller steps: Add tests/export/test_report_spec.py with test_report_spec_validates, verifying emitted report-spec.json includes renderer_profile and validation fails when that field is removed.
• Split task into smaller steps: Add assertions to verify that validation fails when the renderer_profile field is removed from the report-spec
• LLM provider unavailable

---

Auto-generated by capability check