Skip to content

chore: sync workflow templates - #326

Merged
stranske merged 1 commit into
mainfrom
sync/workflows-da74423d2b57
Apr 27, 2026
Merged

stranske merged 1 commit into
mainfrom
sync/workflows-da74423d2b57

Conversation

@stranske

Copy link
Copy Markdown
Owner

Sync Summary

Files Updated

  • source_context.js: Classifies PR workflow source context for issue, local, automation, sync, Dependabot, review follow-up, and direct GitHub work
  • agents_pr_meta_update_body.js: Updates PR body with agent metadata

Files Skipped

  • pr-00-gate.yml: File exists and sync_mode is create_only
  • ci.yml: File exists and sync_mode is create_only
  • dependabot.yml: File exists and sync_mode is create_only
  • llm_slots.json: None

Review Checklist

  • CI passes with updated workflows
  • No repo-specific customizations were overwritten

Source: stranske/Workflows
Source SHA: ee8f0c1dbf1c49292dbf610869156a55ac0966d5
Template hash: da74423d2b57
Sync branch: sync/workflows-da74423d2b57
Consumer repo: stranske/Inv-Man-Intake
Manifest: .github/sync-manifest.yml

Automated sync from stranske/Workflows
Template hash: da74423d2b57

Changes synced from sync-manifest.yml
Copilot AI review requested due to automatic review settings April 27, 2026 04:03
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels Apr 27, 2026
@stranske
stranske merged commit 235b3fb into main Apr 27, 2026
98 of 104 checks passed
@stranske
stranske deleted the sync/workflows-da74423d2b57 branch April 27, 2026 04:11
@github-actions

Copy link
Copy Markdown
Contributor

Provider Comparison Report

Provider Summary

Provider Model Verdict Confidence Summary
openai gpt-5.4 CONCERNS 95% The code changes themselves are readable and appear internally reasonable: they improve source-context resolution messaging, add explicit issue-reference detection before forcing non-issue workflow...
anthropic claude-sonnet-4-6 CONCERNS 82% The PR modifies two JavaScript scripts with reasonable improvements: adding issue-backed detection logic, introducing hasExplicitIssueSyncReference for better PR body parsing, and narrowing the no-...
📋 Full Provider Details (click to expand)

openai

  • Model: gpt-5.4
  • Verdict: CONCERNS
  • Confidence: 95%
  • Scores:
    • Correctness: 4.0/10
    • Completeness: 3.0/10
    • Quality: 7.0/10
    • Testing: 2.0/10
    • Risks: 5.0/10
  • Summary: The code changes themselves are readable and appear internally reasonable: they improve source-context resolution messaging, add explicit issue-reference detection before forcing non-issue workflow context during body sync, and narrow no-automation checkbox matching. However, the merged PR does not satisfy the documented acceptance criteria provided here, which are specifically about syncing workflow/template files (pr-00-gate.yml, ci.yml, dependabot.yml with create_only behavior). Those files are untouched in the diff. Quality is acceptable, but completeness against the stated requirements is not met, and testing coverage for the behavior changes is absent.
  • Concerns:
    • The documented acceptance criteria are workflow/template sync requirements for pr-00-gate.yml, ci.yml, and dependabot.yml, but this PR only changes two JavaScript helper scripts and does not add or modify those workflow files.
    • No code or diff evidence addresses the stated acceptance criterion that pr-00-gate.yml, ci.yml, and dependabot.yml exist with sync_mode=create_only.
    • No tests were added or modified in the diff for the new source-context behavior, so there is no direct verification of the new issue-reference detection logic or the changed no-automation checkbox parsing.
    • The new hasExplicitIssueSyncReference regexes may miss some valid issue-linking phrasings or produce false positives/negatives, and without tests this behavior change is harder to validate.

anthropic

  • Model: claude-sonnet-4-6
  • Verdict: CONCERNS
  • Confidence: 82%
  • Scores:
    • Correctness: 7.0/10
    • Completeness: 3.0/10
    • Quality: 7.0/10
    • Testing: 5.0/10
    • Risks: 7.0/10
  • Summary: The PR modifies two JavaScript scripts with reasonable improvements: adding issue-backed detection logic, introducing hasExplicitIssueSyncReference for better PR body parsing, and narrowing the no-automation checkbox pattern. However, the documented acceptance criteria exclusively reference YAML workflow files (pr-00-gate.yml, ci.yml, dependabot.yml) with sync_mode: create_only, none of which appear in the diff. This mismatch between acceptance criteria and implementation is the primary concern. The code changes themselves are functionally plausible but the removal of the 'human-only' pattern and the behavioral change in resolveNonIssueWorkflowSourceContextForBodySync warrant scrutiny without visible test coverage in the diff.
  • Concerns:
    • Acceptance criteria specify pr-00-gate.yml, ci.yml, and dependabot.yml should exist with sync_mode: create_only, but none of these files are modified or created in this PR diff
    • The actual changes (JavaScript script modifications) align with the Tasks section but not the Acceptance Criteria section, suggesting the acceptance criteria may be auto-generated boilerplate that doesn't reflect the real intent of this PR
    • Removal of 'human-only' pattern from NO_AUTOMATION_CHECKBOX_PATTERN in source_context.js is a behavioral change that could affect PRs previously matched by that pattern - no explanation provided for why this was removed
    • hasExplicitIssueSyncReference uses complex regex patterns that may have edge cases; no unit tests are visible in the diff to validate these patterns
    • The refactoring of resolveNonIssueWorkflowSourceContextForBodySync changes behavior: previously returned null when issueNumber was truthy, now applies additional hasExplicitIssueSyncReference check - this logic change could affect existing workflows

Agreement

  • Verdict: CONCERNS (all providers)
  • Completeness: scores within 1 point (avg 3.0/10, range 3.0-3.0)
  • Quality: scores within 1 point (avg 7.0/10, range 7.0-7.0)

Disagreement

Dimension openai anthropic
Correctness 4.0/10 7.0/10
Testing 2.0/10 5.0/10
Risks 5.0/10 7.0/10

Unique Insights

  • openai: The documented acceptance criteria are workflow/template sync requirements for pr-00-gate.yml, ci.yml, and dependabot.yml, but this PR only changes two JavaScript helper scripts and does not add or modify those workflow files.; No code or diff evidence addresses the stated acceptance criterion that pr-00-gate.yml, ci.yml, and dependabot.yml exist with sync_mode=create_only.; No tests were added or modified in the diff for the new source-context behavior, so there is no direct verification of the new issue-reference detection logic or the changed no-automation checkbox parsing.; The new hasExplicitIssueSyncReference regexes may miss some valid issue-linking phrasings or produce false positives/negatives, and without tests this behavior change is harder to validate.
  • anthropic: Acceptance criteria specify pr-00-gate.yml, ci.yml, and dependabot.yml should exist with sync_mode: create_only, but none of these files are modified or created in this PR diff; The actual changes (JavaScript script modifications) align with the Tasks section but not the Acceptance Criteria section, suggesting the acceptance criteria may be auto-generated boilerplate that doesn't reflect the real intent of this PR; Removal of 'human-only' pattern from NO_AUTOMATION_CHECKBOX_PATTERN in source_context.js is a behavioral change that could affect PRs previously matched by that pattern - no explanation provided for why this was removed; hasExplicitIssueSyncReference uses complex regex patterns that may have edge cases; no unit tests are visible in the diff to validate these patterns; The refactoring of resolveNonIssueWorkflowSourceContextForBodySync changes behavior: previously returned null when issueNumber was truthy, now applies additional hasExplicitIssueSyncReference check - this logic change could affect existing workflows

@stranske
stranske removed the request for review from Copilot April 27, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated Automated sync from Workflows sync Automated sync from Workflows verify:compare

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant