Conversation
Automated sync from stranske/Workflows Template hash: f8490e265811 Changes synced from sync-manifest.yml
🤖 Keepalive Loop StatusPR #839 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
Keepalive Work Log (click to expand)
|
There was a problem hiding this comment.
Pull request overview
Syncs repository workflow templates from stranske/Workflows, extending the weekly metrics workflow to include bot-comment App authentication coverage reporting alongside existing terminal disposition coverage checks.
Changes:
- Add a bot-comment auth coverage preflight step to the weekly metrics workflow and upload its summary artifacts.
- Extend weekly metrics artifact selection to include bot-comment auth coverage artifact families.
- Introduce
.github/scripts/bot_comment_auth_coverage.jsto summarize/enforce bot-comment auth coverage and generate JSON/Markdown reports.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/agents-weekly-metrics.yml |
Runs the new bot-comment auth coverage preflight, includes outputs in artifacts, and honors coverage hard-blocks. |
.github/scripts/weekly_metrics_artifacts.js |
Adds bot-comment auth coverage artifact prefixes/families to weekly artifact selection and priority selection. |
.github/scripts/bot_comment_auth_coverage.js |
New script that scans downloaded artifacts, summarizes bot-comment auth coverage, and emits JSON/Markdown reports with optional enforcement. |
|
|
||
| function summarizeBotCommentAuthCoverage(records = [], options = {}) { | ||
| const policy = normalizePolicy(options); | ||
| const parseErrors = Number(options.parse_errors || options.parseErrors || 0); |
There was a problem hiding this comment.
parse_errors is derived with options.parse_errors || options.parseErrors || 0, which treats an explicit 0 as falsy and can incorrectly fall back to options.parseErrors. Use nullish coalescing (??) or an explicit undefined check so 0 is preserved.
| const parseErrors = Number(options.parse_errors || options.parseErrors || 0); | |
| const parseErrors = Number(options.parse_errors ?? options.parseErrors ?? 0); |
| name.startsWith('bot-comment-auth-coverage-'); | ||
| }); | ||
| return { | ||
| schema: cleanString(report.schema), |
There was a problem hiding this comment.
In normalizeArtifactSelectionSummary, the success-path returns schema: cleanString(report.schema) without a fallback. If the selector report omits schema, downstream output will have an empty schema value; the missing/parse-error paths already provide a default. Consider applying the same default schema in the success path for consistency and robustness.
| schema: cleanString(report.schema), | |
| schema: cleanString(report.schema) || 'workflows-weekly-metrics-artifact-selection/v1', |
Sync Summary
Files Updated
Files Skipped
Review Checklist
Source: stranske/Workflows
Manifest:
.github/sync-manifest.yml