Harden sync review runtime and bot auth contracts - #1843
Merged
Merged
Conversation
Contributor
stranske
force-pushed
the
codex/weekly-metrics-node-setup
branch
from
April 25, 2026 19:21
64bea27 to
6d867f0
Compare
Contributor
🤖 Keepalive Loop StatusPR #1843 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
Contributor
Keepalive Work Log (click to expand)
|
stranske
temporarily deployed
to
agent-high-privilege
April 25, 2026 19:23 — with 
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
Pull request overview
Pins and formalizes the Node runtime contract for the weekly metrics workflow so the repo and consumer template run the Node-based helper scripts under an explicit, stable Node 20 environment.
Changes:
- Add an explicit
actions/setup-nodestep (Node 20) before anynpm/nodeusage in weekly metrics. - Pin
actions/setup-nodeto the resolved v6 commit SHA in both the live workflow and the consumer template. - Extend the workflow invariant test to enforce the Node runtime/pinning/ordering contract.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/workflows/test_workflow_agents_consolidation.py |
Adds invariant assertions to ensure weekly metrics uses pinned setup-node, Node 20, and correct step ordering. |
templates/consumer-repo/.github/workflows/agents-weekly-metrics.yml |
Inserts pinned setup-node v6 SHA with Node 20 before installing Node dependencies. |
.github/workflows/agents-weekly-metrics.yml |
Inserts pinned setup-node v6 SHA with Node 20 before installing Node dependencies. |
| "artifacts/metric-artifacts-selection.json" in text | ||
| ), "Weekly metrics must include selector JSON in uploaded artifacts" | ||
| assert ( | ||
| "uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6" in text |
Comment on lines
+278
to
+279
| assert ( | ||
| 'node-version: "20"' in text |
Comment on lines
+281
to
+285
| assert text.index("Setup Node") < text.index( | ||
| "Install GitHub API dependencies" | ||
| ), "Weekly metrics must setup Node before installing API dependencies" | ||
| assert text.index("Setup Node") < text.index( | ||
| "node .github/scripts/weekly_metrics_artifacts.js" |
stranske
temporarily deployed
to
agent-high-privilege
April 25, 2026 19:25 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Status Summary
Scope
Sync/Dependabot Campaign Queue
Remote discovery found more review-thread work than fits in a full GitHub issue body. The marker below retains the compact machine-readable queue for the local watcher.
Context for Agent
Related Issues/PRs
Tasks
Acceptance criteria
Head SHA: 8a896e5
Latest Runs: ✅ success — Gate
Required: gate: ✅ success