Conversation
Automated sync from stranske/Workflows Template hash: 8c7e6f62db72 Changes synced from sync-manifest.yml
🤖 Keepalive Loop StatusPR #842 | Agent: Codex | Iteration 0/5 Current State
🔍 Failure Classification| Error type | infrastructure | |
Keepalive Work Log (click to expand)
|
There was a problem hiding this comment.
Pull request overview
Syncs workflow templates from stranske/Workflows by extending the weekly metrics workflow to include a new “bot-comment App auth coverage” preflight, plus updating artifact selection logic to pick up the new metrics artifacts.
Changes:
- Add a bot-comment auth coverage preflight step to the weekly metrics workflow and upload its summary artifacts.
- Extend weekly metrics artifact selection to recognize bot-comment auth coverage artifact families.
- Introduce
.github/scripts/bot_comment_auth_coverage.jsto summarize bot-comment auth coverage and produce JSON/Markdown reports.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/agents-weekly-metrics.yml |
Runs the new bot-comment auth coverage preflight and enforces coverage hard-block exit behavior. |
.github/scripts/weekly_metrics_artifacts.js |
Adds bot-comment auth coverage artifact prefixes/families to weekly selection logic. |
.github/scripts/bot_comment_auth_coverage.js |
New summarizer that reads auth coverage JSON records and emits a coverage summary + markdown. |
| run: | | ||
| terminal_status="${TERMINAL_DISPOSITION_COVERAGE_EXIT_STATUS:-0}" | ||
| bot_comment_auth_status="${BOT_COMMENT_AUTH_COVERAGE_EXIT_STATUS:-0}" | ||
| if [ "${terminal_status}" != "0" ] || [ "${bot_comment_auth_status}" != "0" ]; then |
There was a problem hiding this comment.
The hard-block step exits with status 1 but doesn’t print which gate(s) failed or the captured exit codes. Emitting a brief message (e.g., echo the terminal/bot-comment status values and which one triggered the failure) would make scheduled-run failures much easier to triage from logs.
| if [ "${terminal_status}" != "0" ] || [ "${bot_comment_auth_status}" != "0" ]; then | |
| if [ "${terminal_status}" != "0" ] || [ "${bot_comment_auth_status}" != "0" ]; then | |
| echo "Coverage hard-block triggered: terminal_disposition=${terminal_status}, bot_comment_auth=${bot_comment_auth_status}" | |
| if [ "${terminal_status}" != "0" ] && [ "${bot_comment_auth_status}" != "0" ]; then | |
| echo "Failing gates: review-thread terminal coverage and bot-comment auth coverage" | |
| elif [ "${terminal_status}" != "0" ]; then | |
| echo "Failing gate: review-thread terminal coverage" | |
| else | |
| echo "Failing gate: bot-comment auth coverage" | |
| fi |
| const blockers = []; | ||
| if (!latest) { | ||
| blockers.push(`missing-${component}`); | ||
| } else { |
There was a problem hiding this comment.
missing_record_severity: 'no-data' is not respected in the overall coverage status: when a component has no latest record you always add a missing-* blocker (line 237), and later coverageStatus becomes warning whenever blockers.length > 0 (line 278), even if the only issues are missing components marked as no-data. Consider only adding missing-* to the global blockers when the component policy treats missing data as a warning/failure, or track missing-no-data separately so overall status can remain no-data/pass as intended.
Sync Summary
Files Updated
Files Skipped
Review Checklist
Source: stranske/Workflows
Manifest:
.github/sync-manifest.yml