Skip to content

chore: sync workflow templates - #5335

Closed
stranske wants to merge 1 commit into
phase-3from
sync/workflows-c8c8eac6035c
Closed

stranske wants to merge 1 commit into
phase-3from
sync/workflows-c8c8eac6035c

Conversation

@stranske

Copy link
Copy Markdown
Owner

Sync Summary

Files Updated

  • maint-coverage-guard.yml: Coverage guard - daily baseline monitoring with automatic issue creation

Files Skipped

  • pr-00-gate.yml: File exists and sync_mode is create_only
  • ci.yml: File exists and sync_mode is create_only
  • dependabot.yml: File exists and sync_mode is create_only
  • AGENTS.md: Repo keeps historical Agents.md casing to avoid case-only path conflicts
  • llm_slots.json: None

Review Checklist

  • CI passes with updated workflows
  • No repo-specific customizations were overwritten

Source: stranske/Workflows
Source SHA: 08607f6553ee4b376326c59385f0164b9c6f20f1
Template hash: c8c8eac6035c
Sync branch: sync/workflows-c8c8eac6035c
Consumer repo: stranske/Trend_Model_Project
Manifest: .github/sync-manifest.yml

Automated sync from stranske/Workflows
Template hash: c8c8eac6035c

Changes synced from sync-manifest.yml
Copilot AI review requested due to automatic review settings May 26, 2026 06:04
@stranske stranske added sync Automated sync from Workflows automated Automated sync from Workflows labels May 26, 2026
@stranske
stranske temporarily deployed to agent-standard May 26, 2026 06:04 — with GitHub Actions Inactive

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14d7cfcc11

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +163 to +164
const candidate =
runs.find((run) => ['success', 'neutral'].includes(run.conclusion || '')) || runs[0];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve artifact-qualified Gate run selection

Select a Gate run that actually published gate-coverage-trend before setting run_id; this new selection logic picks the newest successful/neutral run regardless of artifacts, so docs-only or otherwise non-coverage runs can be chosen. In that case all artifact downloads are allowed to fail (continue-on-error: true) and tools/coverage_guard.py exits early when no trend payload is present, which silently skips baseline monitoring for that day even if an earlier run has valid coverage artifacts.

Useful? React with 👍 / 👎.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Syncs the maint-coverage-guard workflow template from stranske/Workflows, updating how the workflow discovers the latest Gate (pr-00-gate.yml) run used to download coverage artifacts and drive the daily baseline monitoring.

Changes:

  • Replaced usage of .github/scripts/select_coverage_gate_run with an inline listWorkflowRuns query (optionally using github-api-with-retry.js).
  • Adjusted Gate run selection logic to pick the newest completed run (preferring success/neutral) and simplified the notice output.
Comments suppressed due to low confidence (2)

.github/workflows/maint-coverage-guard.yml:150

  • paginateWithRetry(github, github.rest.actions.listWorkflowRuns, ...) will paginate through all completed Gate runs, which can be thousands and burn API quota/time unnecessarily. Since you only need the most recent eligible run, prefer a single listWorkflowRuns call (or stop pagination once a match is found).
            const runs = await paginateWithRetry(
              github, github.rest.actions.listWorkflowRuns,
              {
                owner,
                repo,
                workflow_id: workflowId,
                status: 'completed',
                per_page: 50,
              },
            );

.github/workflows/maint-coverage-guard.yml:165

  • The selected candidate run is not validated to contain the coverage artifacts (e.g. gate-coverage-trend). If a successful/neutral Gate run completed without uploading artifacts (docs-only/early-exit), the downloads will fail and tools/coverage_guard.py will skip updates due to missing trend payload. Prefer selecting the newest run that actually has the required artifact(s) (or reuse select_coverage_gate_run).
            const candidate =
              runs.find((run) => ['success', 'neutral'].includes(run.conclusion || '')) || runs[0];

github-token: ${{ secrets.GITHUB_TOKEN }}
script: |
const { owner, repo } = context.repo;
const workflowId = '.github/workflows/pr-00-gate.yml';
@stranske

Copy link
Copy Markdown
Owner Author

Closing as stale; newer sync workflow templates PR #5336 exists for the latest Workflows sync wave.

@stranske stranske closed this May 26, 2026
@stranske-keepalive
stranske-keepalive Bot deleted the sync/workflows-c8c8eac6035c branch May 30, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated Automated sync from Workflows sync Automated sync from Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants