Conversation
Automated sync from stranske/Workflows Template hash: f823f728bf45 Changes synced from sync-manifest.yml
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8df49ca033
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (const run of runs) { | ||
| const artifacts = await withRetry(() => |
There was a problem hiding this comment.
This loop now considers every completed Gate run, so the first run with a gate-coverage-trend artifact is selected even when the run conclusion is failure/cancelled. The previous selector explicitly limited candidates to successful/neutral runs, which avoids baselining coverage on failed CI executions. If failed runs still publish the trend artifact, this change can drive incorrect coverage-guard issues from invalid data.
Useful? React with 👍 / 👎.
| const artifacts = await withRetry(() => | ||
| github.rest.actions.listWorkflowRunArtifacts({ | ||
| owner, | ||
| repo, | ||
| run_id: run.id, |
There was a problem hiding this comment.
The artifact lookup is no longer wrapped in a per-run try/catch, so a single non-retryable API error from listWorkflowRunArtifacts aborts the entire discovery step instead of skipping that run and checking older ones. This is a regression from the prior helper behavior and can make the daily coverage monitor fail even though a valid older run exists.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR syncs the maint-coverage-guard.yml workflow template from the central Workflows repo, updating how the maintenance job discovers the most recent Gate workflow run to use as the coverage baseline input.
Changes:
- Replaced the shared
select_coverage_gate_runhelper usage with inline GitHub API pagination + artifact inspection logic. - Added optional use of
.github/scripts/github-api-with-retry.js(with a fallback) to make API calls more resilient. - Simplified the “Using Gate workflow run …” notice output.
| for (const run of runs) { | ||
| const artifacts = await withRetry(() => | ||
| github.rest.actions.listWorkflowRunArtifacts({ | ||
| owner, | ||
| repo, | ||
| run_id: run.id, | ||
| per_page: 100, | ||
| }), | ||
| ); |
|
Closing as stale; newer sync workflow templates PR #5337 exists for the latest Workflows sync wave. |
Sync Summary
Files Updated
Files Skipped
Review Checklist
Source: stranske/Workflows
Source SHA:
c3f00747347439f9bc6f023734df6f8b7aa682c9Template hash:
f823f728bf45Sync branch:
sync/workflows-f823f728bf45Consumer repo:
stranske/Trend_Model_ProjectManifest:
.github/sync-manifest.yml