Conversation
Automated sync from stranske/Workflows Template hash: 12bc63cd403e Changes synced from sync-manifest.yml
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15b0f40681
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await resolveSourceContextRepairComment({ | ||
| github, | ||
| owner, | ||
| repo, | ||
| prNumber: pr.number, |
There was a problem hiding this comment.
Defer source-context warning resolution until issue fetch succeeds
This call resolves the <!-- missing-issue-warning --> comment before confirming that issueNumber can actually be read from GitHub. If the PR points to a stale/invalid issue (or issues.get fails), the workflow still rewrites the warning to “Workflow source detected” and then fails later, leaving a misleading “resolved” comment even though synchronization did not succeed. Resolve the warning only after a successful issue fetch.
Useful? React with 👍 / 👎.
| /\b(?:close[sd]?|closing|fix(?:e[sd])?|fixing|resolve[sd]?|resolving|address(?:e[sd])?|addressing)\s*[:#-]?\s*#([0-9]+)\b/gi, | ||
| /\b(?:(?:relate[sd]?\s+to|references?)\s+(?:issue\s+)?|(?:source|github|linked)\s+issue\s*)[:#-]?\s*#([0-9]+)\b/gi, | ||
| ]; |
There was a problem hiding this comment.
Recognize
Refs #123 in explicit issue-sync detection
extractExplicitIssueSyncNumbers omits the common refs keyword, but extractIssueNumberFromPull still treats Refs #123 as a valid issue reference. With a non-issue workflow marker present, this mismatch causes resolveNonIssueWorkflowSourceContextForBodySync to incorrectly keep skipping issue-backed body sync for PRs that use Refs #.... Add refs? (and keep parity with issue-number extraction rules) to avoid inconsistent behavior.
Useful? React with 👍 / 👎.
Sync Summary
Files Updated
Files Skipped
Review Checklist
Source: stranske/Workflows
Source SHA:
cfa51b59de2b1bb7cf15b4702794da43115bef26Template hash:
12bc63cd403eSync branch:
sync/workflows-12bc63cd403eConsumer repo:
stranske/Trend_Model_ProjectManifest:
.github/sync-manifest.yml