Skip to content

[Follow-up] Unmet criteria from PR #166 #167

Description

@github-actions

Source

Scope

Address unmet acceptance criteria from PR #166.

Original scope:

  • The verifier CI query (verifier_ci_query.js) currently makes a single API call to fetch workflow run results. If the GitHub API returns a transient error (rate limit, timeout, network hiccup), the query fails silently and the verifier sees missing CI results.
  • This can cause false negatives where the verifier marks test-related criteria as NOT MET due to API failures rather than actual CI failures.
  • ### Current Behavior
  • - Single API call per workflow
  • - Failures logged as warnings but not retried
  • - Missing results treated as "not found"
  • ### Desired Behavior
  • - Retry transient failures with exponential backoff
  • - Distinguish between "CI not run" and "API error"
  • - Log retry attempts for debugging

Tasks

  • Satisfy: Transient API failures (429, 500, 502, 503, 504) are retried up to 3 times
  • Satisfy: Successful retry results in correct CI data being returned
  • Satisfy: Max retry exceeded results in clear error message, not silent "not found"
  • Satisfy: Tests cover retry success and retry exhaustion scenarios
  • Satisfy: Selftest CI passes

Acceptance Criteria

  • Transient API failures (429, 500, 502, 503, 504) are retried up to 3 times
  • Successful retry results in correct CI data being returned
  • Max retry exceeded results in clear error message, not silent "not found"
  • Tests cover retry success and retry exhaustion scenarios
  • Selftest CI passes

Implementation Notes

Original implementation in PR #166.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent:codexAgent-created issues from Codex

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions