Skip to content

[sync-review] Fix upstream manifest-synced paths blocking stranske/Manager-Database#1683 #3459

Description

@stranske

Why

Consumer sync PR stranske/Manager-Database#1683 carries an unresolved Copilot review thread on manifest-synced scripts/langchain/issue_dedup.py. The upstream source in this repository must gain regression coverage for non-finite similarity scores so the next sync regeneration outdates that thread and the delivery PR can merge.

Scope

Add focused unit tests in Workflows for the new non-finite score handling branch in scripts/langchain/issue_dedup.py (NaN, positive infinity, negative infinity, and a valid result after them).

Non-Goals

  • Changing the consumer PR directly; fixes land in Workflows main and propagate via sync.
  • Altering production behavior beyond what the existing code already implements.

Tasks

  • In tests/scripts/test_issue_dedup.py, add regression coverage for non-finite similarity scores in scripts/langchain/issue_dedup.py: NaN, positive infinity, negative infinity, and a valid match after invalid scores.
  • Run ./scripts/sync_templates.sh if the consumer template copy of scripts/langchain/issue_dedup.py is manifest-synced.

Acceptance Criteria

  • pytest tests/scripts/test_issue_dedup.py -q passes, including the new non-finite score cases.
  • Deliberate-break gate: remove the non-finite score guard in scripts/langchain/issue_dedup.py → the new test must FAIL → revert.

Implementation Notes

Review thread: stranske/Manager-Database#1683 on scripts/langchain/issue_dedup.py. Upstream source verified at that path in this repository.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions