Why
Consumer sync PR stranske/Manager-Database#1683 carries an unresolved Copilot review thread on manifest-synced scripts/langchain/issue_dedup.py. The upstream source in this repository must gain regression coverage for non-finite similarity scores so the next sync regeneration outdates that thread and the delivery PR can merge.
Scope
Add focused unit tests in Workflows for the new non-finite score handling branch in scripts/langchain/issue_dedup.py (NaN, positive infinity, negative infinity, and a valid result after them).
Non-Goals
- Changing the consumer PR directly; fixes land in Workflows main and propagate via sync.
- Altering production behavior beyond what the existing code already implements.
Tasks
Acceptance Criteria
Implementation Notes
Review thread: stranske/Manager-Database#1683 on scripts/langchain/issue_dedup.py. Upstream source verified at that path in this repository.
Why
Consumer sync PR stranske/Manager-Database#1683 carries an unresolved Copilot review thread on manifest-synced
scripts/langchain/issue_dedup.py. The upstream source in this repository must gain regression coverage for non-finite similarity scores so the next sync regeneration outdates that thread and the delivery PR can merge.Scope
Add focused unit tests in Workflows for the new non-finite score handling branch in
scripts/langchain/issue_dedup.py(NaN, positive infinity, negative infinity, and a valid result after them).Non-Goals
Tasks
tests/scripts/test_issue_dedup.py, add regression coverage for non-finite similarity scores inscripts/langchain/issue_dedup.py:NaN, positive infinity, negative infinity, and a valid match after invalid scores../scripts/sync_templates.shif the consumer template copy ofscripts/langchain/issue_dedup.pyis manifest-synced.Acceptance Criteria
pytest tests/scripts/test_issue_dedup.py -qpasses, including the new non-finite score cases.scripts/langchain/issue_dedup.py→ the new test must FAIL → revert.Implementation Notes
Review thread: stranske/Manager-Database#1683 on
scripts/langchain/issue_dedup.py. Upstream source verified at that path in this repository.