Skip to content

[Follow-up] Unmet criteria from PR #386 #388

Description

@github-actions

Source

Scope

Address unmet acceptance criteria from PR #386.

Original scope:
Test coverage is at 71.60% with 17 scripts below 95% coverage. Low coverage makes scripts risky to modify and harder to maintain.

Tasks

  • IMPORTANT: A task is NOT complete until you run pytest tests/ --cov=scripts --cov-report=term-missing and verify the script shows ≥95% in the Cover column. Do not mark a task complete without verifying the actual coverage percentage.

Acceptance Criteria

  • Before marking ANY task complete, you MUST:
  • 1. Run pytest tests/ --cov=scripts --cov-report=term-missing
  • 2. Find the script in the output table
  • 3. Confirm the Cover column shows ≥95%
  • 4. Only then mark that specific task complete
  • Overall coverage ≥95%
  • Each script in scripts/ shows ≥95% in coverage output
  • All existing tests pass

Implementation Notes

Verifier confirmed these criteria were met:

  • ✓ New tests in tests/scripts/ directory

Original implementation in PR #386.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent:codexAgent-created issues from Codex

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions