Skip to content

Avoid closing active campaign issues from PR preambles - #1898

Merged
stranske merged 2 commits into
mainfrom
campaign-issue-nonclosing-preamble
Apr 26, 2026
Merged

stranske merged 2 commits into
mainfrom
campaign-issue-nonclosing-preamble

Conversation

@stranske

@stranske stranske commented Apr 26, 2026

Copy link
Copy Markdown
Owner

Source: Issue #1836

Related to campaign issue #1836

Automated Status Summary

Scope

Sync/Dependabot Campaign Queue

Remote GitHub Actions owns discovery for sync-generated and Dependabot PR rounds. Local Codex should only claim items from this issue when needs-local-codex work is queued.

Summary

Context for Agent

Related Issues/PRs

Tasks

  • Updated: 2026-04-26T13:55:31.783Z
  • Repos checked: 11/11
  • Open sync PRs: 461
  • Open Dependabot PRs: 0
  • Active review threads queued: 710
  • Items needing local Codex: 0
  • Actionable local Codex items: 0
  • Claimable local Codex items: 0
  • Source-fixed candidates: 0
  • Superseded sync candidates: 120
  • Finished local results without published source changes: 0
  • Claimed local Codex items: 0
  • Next claim lease expires: -

Acceptance criteria

  • Status: local-codex-superseded-sync-candidate
  • Source repo: stranske/Workflows
  • Source sync state: superseded (PR a3e3f6fa23d5 / current ede2607c77be)
    • scripts/aggregate_agent_metrics.py:274 (copilot-pull-request-reviewer): The unsupported-model list is configured via UNSUPPORTED_VERIFIER_MODELS here, but the terminal-disposition coverage ...

Copilot AI review requested due to automatic review settings April 26, 2026 14:03
@stranske stranske added codex agent:codex Agent-created issues from Codex from:codex Created from Codex agent labels Apr 26, 2026
@agents-workflows-bot

agents-workflows-bot Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor

🤖 Keepalive Loop Status

PR #1898 | Agent: Codex | Iteration 2/5

Current State

Metric Value
Iteration progress [####------] 2/5
Action run (ready)
Gate success
Tasks 0/4 complete
Timeout 45 min (default)
Timeout usage 14m elapsed (32%, 31m remaining)
Keepalive ✅ enabled
Autofix ❌ disabled

Last Codex Run

Result Value
Status ✅ Success
Changes ✅ 4 file(s)
Commit 20194ee

Codex output:

No output captured

📋 Task Reconciliation Needed

⚠️ Codex changed 4 file(s) but didn't check off any tasks.

Next iteration should:

  1. Review the changes made and determine which tasks were addressed
  2. Update the PR body to check off completed task checkboxes
  3. If work was unrelated to tasks, continue with remaining tasks

🧠 Task Analysis

| Provider | ℹ️ anthropic |
| Model | claude-sonnet-4-5-20250929 |
| Confidence | 75% |

⚠️ Primary provider (GitHub Models) was unavailable; used anthropic instead.

@agents-workflows-bot

agents-workflows-bot Bot commented Apr 26, 2026

Copy link
Copy Markdown
Contributor
Keepalive Work Log (click to expand)
# Time (UTC) Agent Action Result Files Tasks Progress Commit Gate
0 2026-04-26 14:04:35 Codex wait (gate-pending-transient) skipped 0 0/4
0 2026-04-26 14:05:10 Codex wait (gate-cancelled-transient-transient) skipped 0 0/4 cancelled
1 2026-04-26 14:11:18 Codex run (bypass-rate-limit-gate) success 5 file(s) 0 0/4 6cb24d2 cancelled
2 2026-04-26 14:18:20 Codex run (ready) success 4 file(s) 0 0/4 20194ee success

@stranske
stranske merged commit 745e2f0 into main Apr 26, 2026
84 of 86 checks passed
@stranske
stranske deleted the campaign-issue-nonclosing-preamble branch April 26, 2026 14:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the PR-body preamble generator to avoid auto-closing durable campaign tracking issues (while preserving the hidden <!-- meta:issue:N --> traceability marker), preventing campaign PR merges from closing the campaign queue issue.

Changes:

  • Detects “campaign” source issues via labels and replaces Closes #N with a non-closing reference for those issues.
  • Threads the fetched source issue payload into buildPreamble so label-based logic can be applied.
  • Adds a unit test ensuring campaign issues are not closed by the generated preamble.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/scripts/agents_pr_meta_update_body.js Adds campaign-issue detection and conditionally emits a non-closing reference instead of Closes #N.
templates/consumer-repo/.github/scripts/agents_pr_meta_update_body.js Intended template mirror of the preamble behavior for consumer repos.
.github/scripts/__tests__/agents-pr-meta-update-body.test.js Adds coverage ensuring campaign issues are referenced without closing keywords.

Comment on lines +940 to +944
if (isCampaignIssue(sections.sourceIssue)) {
lines.push(`Related to campaign issue #${sections.issueNumber}`, '');
} else {
lines.push(`Closes #${sections.issueNumber}`, '');
}

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consumer template copy of this script appears to be out of sync: templates/consumer-repo/.github/scripts/agents_pr_meta_update_body.js does not currently include isCampaignIssue / issueLabelNames or the updated buildPreamble behavior, so consumer repos would still emit Closes #N for campaign issues. Please mirror this change into the template file as required for consumer-facing scripts (per CLAUDE.md editing rules).

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:codex Agent-created issues from Codex codex from:codex Created from Codex agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants