Follow up #2528: upload LangSmith fleet artifact under registry name

[stranske]

Summary

• Follow up merged PR [codex] Ensure LangSmith fleet fallback artifacts #2528 by uploading the fallback LangSmith fleet telemetry artifact as the exact registry artifact name langsmith-fleet.ndjson.
• Update the reusable CI workflow contract test to prevent reintroducing the caller artifact prefix.

Validation

• python -m pytest tests/workflows/test_reusable_ci_workflow.py -q -> 9 passed
• git diff --check -> passed

This preserves the review-fix commit that was pushed after #2528 merged at its previous head.

Summary by CodeRabbit

• Bug Fixes

  • Standardized the uploaded fleet telemetry artifact name to a fixed value, improving consistency and reducing naming mismatches during CI uploads.
  • Improved fleet artifact download in CI by updating the artifact listing approach to use a pagination helper, while keeping the existing artifact selection behavior.

• Tests

  • Updated workflow tests to reflect the new fixed artifact naming and the adjusted CI implementation details.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cdd36950-f7c7-455d-b343-aa587eeb9bae

📥 Commits

Reviewing files that changed from the base of the PR and between 4787e41 and 953aef5.

📒 Files selected for processing (2)

• .github/workflows/maint-81-langsmith-fleet-conformance.yml
• tests/workflows/test_langsmith_fleet_conformance_workflow.py

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• stranske/Template (auto-detected)
• stranske/Fine-Art-Archive (auto-detected)
• stranske/Ready (auto-detected)
• stranske/Workflows-Integration-Tests (auto-detected)

---

📝 Walkthrough

Walkthrough

The LangSmith fleet telemetry upload step now uses the fixed artifact name langsmith-fleet.ndjson, and the conformance workflow now paginates artifact listing before filtering candidates. Matching tests were updated for both workflow changes.

Changes

LangSmith Fleet Workflow Updates

Layer / File(s)	Summary
Fixed artifact name .github/workflows/reusable-10-ci-python.yml, tests/workflows/test_reusable_ci_workflow.py	The LangSmith fleet telemetry upload step uses the literal langsmith-fleet.ndjson, and the reusable workflow test asserts that exact with.name value.
Paginated artifact listing .github/workflows/maint-81-langsmith-fleet-conformance.yml, tests/workflows/test_langsmith_fleet_conformance_workflow.py	The conformance workflow now loads repository artifacts through github.paginate(github.rest.actions.listArtifactsForRepo, ...), and the test asserts the paginated call shape and the candidate-filtering line.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• stranske/Workflows#2473: Modifies the reusable Python CI workflow’s LangSmith fleet telemetry upload step and the matching artifact-name test.
• stranske/Workflows#2528: Touches the same LangSmith fleet workflow area, including artifact upload naming and the conformance workflow’s artifact selection logic.

Suggested labels

autofix:patch

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: uploading the LangSmith fleet artifact under its registry name as a follow-up to #2528.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/langsmith-fleet-fallback-artifact

---

_{Comment @coderabbitai help to get the list of available commands.}

[stranske]

Closer rebase update 2026-06-24T13:41Z: rebased the follow-up branch onto current origin/main after #2528 merged via squash, so #2530 now contains only commit 4787e41b and the two-file artifact-name fix. Validation after rebase: python -m pytest tests/workflows/test_reusable_ci_workflow.py -q -> 9 passed; git diff --check origin/main..HEAD -> passed. Waiting on fresh PR CI/CodeRabbit after force-with-lease push.

[agents-workflows-bot]

Workflow source detected

PR #2530 now has valid workflow source context (origin=review_followup).

No linked GitHub issue is required for this PR.

[chatgpt-codex-connector]

💡 Codex Review

Workflows/.github/workflows/maint-81-langsmith-fleet-conformance.yml

Lines 71 to 74 in ab7f0de

	const candidates = artifacts.data.artifacts.filter((item) =>
	!item.expired &&
	(item.name === entry.artifact_name || item.name.endsWith(entry.artifact_name))
	);

Paginate artifact lookup before local suffix filtering

After removing the exact name: entry.artifact_name API filter, this now filters only the first page returned by listArtifactsForRepo (per_page: 100, with no page loop or github.paginate). In any registered repo with more than 100 newer non-fleet artifacts, an existing langsmith-fleet.ndjson or trusted prefixed variant falls off the page and the conformance workflow reports the repo as missing even though the artifact exists. Please paginate the artifact listing before applying the exact/suffix filters, or keep the exact-name API query and use paginated fallback only for suffix candidates.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

Runner dispatch state for codex on PR #2530. Do not edit.

[stranske-keepalive]

🤖 Keepalive Loop Status

PR #2530 | Agent: Codex | Iteration 0/12

Current State

Metric	Value
Iteration progress	[----------] 0/12
Action	skip (needs-human)
Disposition	skipped
Gate	success
Tasks	0/4 complete
Timeout	45 min (default)
Timeout usage	0m elapsed (2%, 45m remaining)
Keepalive	✅ enabled
Autofix	❌ disabled

🔍 Failure Classification

| Error type | infrastructure |
| Error category | unknown |
| Suggested recovery | Capture logs and context; retry once and escalate if the issue persists. |

⚠️ Failure Tracking

| Consecutive failures | 3/3 |
| Reason | agent-run-failed |

[github-actions]

⚠️ Codex keepalive run failed

Field	Value
Exit Code	1
Error Category	unknown
Error Type	codex
Run	View logs

🔧 Suggested Recovery

Capture logs and context; retry once and escalate if the issue persists.

📝 What to do

1. Check the workflow logs for detailed error output
2. If this is a configuration issue, update the relevant settings
3. If the error persists, consider adding the needs-human label for manual review
4. Re-run the workflow once the issue is resolved

Output summary

Your access token could not be refreshed because your refresh token was revoked. Please log out and sign in again.

[agents-workflows-bot]

Keepalive Work Log (click to expand)

#	Time (UTC)	Agent	Action	Result	Files	Tasks	Progress	Commit	Gate
0	2026-06-24 13:43:41	Codex	run (agent-run-failed)	failure	3 file(s)	0	0/4	—	success
0	2026-06-24 14:11:33	Codex	run (agent-run-failed) retry	failure	3 file(s)	0	0/4	—	success
0	2026-06-24 14:32:36	Codex	run (agent-run-failed-repeat)	failure	3 file(s)	0	0/4	—	success
0	2026-06-24 14:33:24	Codex	skip (needs-human)	skipped	—	0	0/4	—	—
0	2026-06-24 14:37:25	Codex	skip (needs-human)	skipped	—	0	0/4	—	success
0	2026-06-24 15:21:04	Codex	skip (needs-human) retry	skipped	—	0	0/4	—	success

[stranske]

Closer review-fix update 2026-06-24T14:26Z: addressed the Codex pagination finding by switching the LangSmith fleet conformance artifact lookup to github.paginate(github.rest.actions.listArtifactsForRepo, ...) before applying exact/suffix artifact-name filters. Also added the missing workflow-source:review_followup marker and cleared stale agent:needs-attention because current branch work is local and validated, not human-blocked. Validation after commit 953aef5b: python -m pytest tests/workflows/test_reusable_ci_workflow.py tests/workflows/test_langsmith_fleet_conformance_workflow.py -q -> 10 passed; git diff --check origin/main..HEAD -> passed. Waiting on fresh post-push PR checks.

[stranske]

Closer merge audit 2026-06-24T15:25Z: direct readback shows #2530 is non-draft, MERGEABLE/CLEAN, has zero review threads, CodeRabbit SUCCESS/no actionable comments, and required Gate/Selftest checks green on head 953aef5. The stale needs-human/agent:needs-attention labels came from Codex keepalive token-refresh failures after the local fix was already pushed and validated; they are not product or code blockers. This is a no-source review_followup PR, so no verify:* label is expected after merge.