Skip to content

fix(security): pass belt-dispatcher workflow_dispatch inputs via env instead of script interpolation #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 3 commits into from
Aug 16, 2026
Merged

fix(security): pass belt-dispatcher workflow_dispatch inputs via env instead of script interpolation #3127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb5baac
fix(security): pass belt-dispatcher inputs via env, not script interp…
stranske Aug 16, 2026
68530e5
fix(security): same fix in the consumer template synced to all consumers
stranske Aug 16, 2026
2190bf1
chore: re-baseline belt-dispatcher drift fingerprints after the env: fix
stranske Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/agents-71-codex-belt-dispatcher.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,9 @@ jobs:
- name: Resolve candidate issue
id: pick
uses: actions/github-script@v9
env:
FORCE_ISSUE: ${{ inputs.force_issue }}
AGENT_KEY: ${{ inputs.agent_key }}
with:
github-token: ${{ env.GH_DISPATCH_TOKEN }}
script: |
Expand All @@ -234,8 +237,8 @@ jobs:
core,
task: 'belt-dispatcher-pick',
});
const forced = '${{ inputs.force_issue }}';
const agentKey = String('${{ inputs.agent_key }}' || 'codex').trim().toLowerCase() || 'codex';
const forced = process.env.FORCE_ISSUE || '';
const agentKey = String(process.env.AGENT_KEY || 'codex').trim().toLowerCase() || 'codex';
const { owner, repo } = context.repo;

const summary = core.summary;
Expand Down
6 changes: 3 additions & 3 deletions config/template-drift-allowlist.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ reason = Intentional divergence re-reviewed 2026-08-09: root intake now records
[pair.2]
main = .github/workflows/agents-71-codex-belt-dispatcher.yml
template = templates/consumer-repo/.github/workflows/agents-71-codex-belt-dispatcher.yml
main_sha256 = 4c00b0622181cd89c09f9297446c65045538245789809ca5fc899592d26af482
template_sha256 = 53a57369e4d0f526edc88bdf4bbc079ee095ccd41a9a7fe37e0d9e0b828be8e3
reason = Existing reviewed baseline drift re-baselined 2026-06-20: exported Orchestrator skill inputs were added to both root and consumer dispatcher surfaces while preserving consumer action pinning and Codex-specific wording.
main_sha256 = 0e9a4c7e7b120985fd9684a9e4f89049601b2bbc0b9da9bee5510d3ec1c3c175
template_sha256 = 6a7b6e203f6ac2837bc09dc2dc6620faa37b72cb78068af1bb77779e246cb1dd
reason = Intentional divergence re-baselined 2026-08-16: workflow_dispatch inputs (force_issue, agent_key) are now passed to the github-script step via step-level env: and read through process.env instead of being interpolated into the script body, removing a script-injection surface that caused GitHub to block the workflow as possibly malicious in consumer repos. Applied identically to both surfaces; consumer action pinning and Codex-specific wording preserved.

[pair.3]
main = .github/workflows/agents-72-codex-belt-worker.yml
Expand Down
7 changes: 5 additions & 2 deletions templates/consumer-repo/.github/workflows/agents-71-codex-belt-dispatcher.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,9 @@ jobs:
- name: Resolve candidate issue
id: pick
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9
env:
FORCE_ISSUE: ${{ inputs.force_issue }}
AGENT_KEY: ${{ inputs.agent_key }}
with:
github-token: ${{ env.GH_DISPATCH_TOKEN }}
script: |
Expand All @@ -234,8 +237,8 @@ jobs:
core,
task: 'codex-belt-dispatcher-pick',
});
const forced = '${{ inputs.force_issue }}';
const agentKey = String('${{ inputs.agent_key }}' || 'codex').trim().toLowerCase() || 'codex';
const forced = process.env.FORCE_ISSUE || '';
const agentKey = String(process.env.AGENT_KEY || 'codex').trim().toLowerCase() || 'codex';
const { owner, repo } = context.repo;

const summary = core.summary;
Expand Down
Loading