Skip to content

fix: allow Maint 71 delivery reconciliation #3131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 2 commits into from
Aug 16, 2026
Merged

fix: allow Maint 71 delivery reconciliation #3131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41e30bb
fix: accept Maint 71 delivery selectors
codex-automation Aug 16, 2026
00f4313
chore(autofix): formatting/lint
github-actions[bot] Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/maint-71-merge-sync-prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,13 @@ jobs:
process.env.DISPATCH_SYNC_HASH,
].map((value) => String(value || '').trim()).find(Boolean) || '';
const selector = raw.startsWith(prefix) ? raw.slice(prefix.length) : raw;
if (selector && !['candidate', 'campaign'].includes(selector)) {
throw new Error('active sync selector must be candidate or campaign');
const namedSelectors = new Set(['candidate', 'campaign', 'delivery', 'dev-tool']);
const legacyHash = /^[0-9a-f]{12,64}$/i.test(selector);
if (selector && !namedSelectors.has(selector) && !legacyHash) {
throw new Error(
'active sync selector must be candidate, campaign, delivery, dev-tool, ' +
'or a legacy hex hash',
);
}
fs.appendFileSync(process.env.GITHUB_OUTPUT, `selector=${selector}\n`);
fs.appendFileSync(process.env.GITHUB_OUTPUT, `candidate=${selector === 'candidate'}\n`);
Expand Down
4 changes: 3 additions & 1 deletion tests/workflows/test_sync_delivery_liveness.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ def test_maint71_has_proof_bound_review_resolution_and_exact_evidence_promotion(
assert "canary_evidence_json: JSON.stringify(evidence)" in workflow
assert "cancel-in-progress: false" in workflow
assert "EXCLUDED_REPOS_INPUT: stranske/Collab-Admin" in workflow
assert "active sync selector must be candidate or campaign" in workflow
assert "['candidate', 'campaign', 'delivery', 'dev-tool']" in workflow
assert "/^[0-9a-f]{12,64}$/i.test(selector)" in workflow
assert "active sync selector must be candidate, campaign, delivery, dev-tool, " in workflow
assert "'stale_closed'" in workflow
assert "paginateWithRetry(api.rest.actions.listWorkflowRuns" in workflow
assert "Maint 71 requires OWNER_PR_PAT" in executor
Expand Down
Loading