Skip to content

fix(workflows): stop passing the whole secrets context, fleet-wide #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 1 commit into from
Aug 23, 2026
Merged

fix(workflows): stop passing the whole secrets context, fleet-wide #3209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/agents-63-issue-intake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,12 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.service_bot_pat }}
owner_pr_pat: ${{ secrets.owner_pr_pat }}
workflows_app_id: ${{ secrets.workflows_app_id }}
workflows_app_private_key: ${{ secrets.workflows_app_private_key }}
- name: Echo received inputs
run: |
echo "Inputs JSON:"
Expand Down Expand Up @@ -1505,8 +1509,12 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.service_bot_pat }}
owner_pr_pat: ${{ secrets.owner_pr_pat }}
workflows_app_id: ${{ secrets.workflows_app_id }}
workflows_app_private_key: ${{ secrets.workflows_app_private_key }}

- name: Format issues
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/agents-64-verify-agent-assignment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}


Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/agents-71-codex-belt-dispatcher.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,11 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}

- name: Resolve Workflows ref
id: workflows_ref
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/agents-72-codex-belt-worker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,11 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ env.GH_BELT_TOKEN }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}

- name: Resolve Workflows ref
id: workflows_ref
Expand Down Expand Up @@ -643,8 +646,11 @@ jobs:
if: ${{ steps.parallel.outputs.allowed == 'true' && (inputs.keepalive != true || steps.keepalive_gate.outputs.action != 'skip') }}
uses: ./.belt-tools/.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ env.GH_BELT_TOKEN }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}

- name: Validate ledger base branch
if: ${{ steps.parallel.outputs.allowed == 'true' && (inputs.keepalive != true || steps.keepalive_gate.outputs.action != 'skip') }}
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/agents-73-codex-belt-conveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,11 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}



Expand Down
16 changes: 15 additions & 1 deletion .github/workflows/agents-autofix-dispatcher.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,22 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ steps.app_token.outputs.token || github.token }}
service_bot_pat: ${{ secrets.SERVICE_BOT_PAT }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
owner_pr_pat: ${{ secrets.OWNER_PR_PAT }}
agents_automation_pat: ${{ secrets.AGENTS_AUTOMATION_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}
keepalive_app_id: ${{ secrets.KEEPALIVE_APP_ID }}
keepalive_app_private_key: ${{ secrets.KEEPALIVE_APP_PRIVATE_KEY }}
gh_app_id: ${{ secrets.GH_APP_ID }}
gh_app_private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
app_1_id: ${{ secrets.APP_1_ID }}
app_1_private_key: ${{ secrets.APP_1_PRIVATE_KEY }}
app_2_id: ${{ secrets.APP_2_ID }}
app_2_private_key: ${{ secrets.APP_2_PRIVATE_KEY }}

- name: Dispatch autofix workflow
uses: actions/github-script@v9
Expand Down
32 changes: 30 additions & 2 deletions .github/workflows/agents-autofix-loop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,22 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.SERVICE_BOT_PAT }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
owner_pr_pat: ${{ secrets.OWNER_PR_PAT }}
agents_automation_pat: ${{ secrets.AGENTS_AUTOMATION_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}
keepalive_app_id: ${{ secrets.KEEPALIVE_APP_ID }}
keepalive_app_private_key: ${{ secrets.KEEPALIVE_APP_PRIVATE_KEY }}
gh_app_id: ${{ secrets.GH_APP_ID }}
gh_app_private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
app_1_id: ${{ secrets.APP_1_ID }}
app_1_private_key: ${{ secrets.APP_1_PRIVATE_KEY }}
app_2_id: ${{ secrets.APP_2_ID }}
app_2_private_key: ${{ secrets.APP_2_PRIVATE_KEY }}



Expand Down Expand Up @@ -955,8 +969,22 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.SERVICE_BOT_PAT }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
owner_pr_pat: ${{ secrets.OWNER_PR_PAT }}
agents_automation_pat: ${{ secrets.AGENTS_AUTOMATION_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}
keepalive_app_id: ${{ secrets.KEEPALIVE_APP_ID }}
keepalive_app_private_key: ${{ secrets.KEEPALIVE_APP_PRIVATE_KEY }}
gh_app_id: ${{ secrets.GH_APP_ID }}
gh_app_private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
app_1_id: ${{ secrets.APP_1_ID }}
app_1_private_key: ${{ secrets.APP_1_PRIVATE_KEY }}
app_2_id: ${{ secrets.APP_2_ID }}
app_2_private_key: ${{ secrets.APP_2_PRIVATE_KEY }}

- name: Collect metrics
id: collect
Expand Down
32 changes: 30 additions & 2 deletions .github/workflows/agents-bot-comment-handler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,22 @@ jobs:
if: steps.eligibility.outputs.should-run == 'true'
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.SERVICE_BOT_PAT }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
owner_pr_pat: ${{ secrets.OWNER_PR_PAT }}
agents_automation_pat: ${{ secrets.AGENTS_AUTOMATION_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}
keepalive_app_id: ${{ secrets.KEEPALIVE_APP_ID }}
keepalive_app_private_key: ${{ secrets.KEEPALIVE_APP_PRIVATE_KEY }}
gh_app_id: ${{ secrets.GH_APP_ID }}
gh_app_private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
app_1_id: ${{ secrets.APP_1_ID }}
app_1_private_key: ${{ secrets.APP_1_PRIVATE_KEY }}
app_2_id: ${{ secrets.APP_2_ID }}
app_2_private_key: ${{ secrets.APP_2_PRIVATE_KEY }}



Expand Down Expand Up @@ -576,8 +590,22 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.SERVICE_BOT_PAT }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
owner_pr_pat: ${{ secrets.OWNER_PR_PAT }}
agents_automation_pat: ${{ secrets.AGENTS_AUTOMATION_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}
keepalive_app_id: ${{ secrets.KEEPALIVE_APP_ID }}
keepalive_app_private_key: ${{ secrets.KEEPALIVE_APP_PRIVATE_KEY }}
gh_app_id: ${{ secrets.GH_APP_ID }}
gh_app_private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
app_1_id: ${{ secrets.APP_1_ID }}
app_1_private_key: ${{ secrets.APP_1_PRIVATE_KEY }}
app_2_id: ${{ secrets.APP_2_ID }}
app_2_private_key: ${{ secrets.APP_2_PRIVATE_KEY }}

- name: Remove trigger label
uses: actions/github-script@v9
Expand Down
16 changes: 15 additions & 1 deletion .github/workflows/agents-capability-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,22 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.SERVICE_BOT_PAT }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
owner_pr_pat: ${{ secrets.OWNER_PR_PAT }}
agents_automation_pat: ${{ secrets.AGENTS_AUTOMATION_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}
keepalive_app_id: ${{ secrets.KEEPALIVE_APP_ID }}
keepalive_app_private_key: ${{ secrets.KEEPALIVE_APP_PRIVATE_KEY }}
gh_app_id: ${{ secrets.GH_APP_ID }}
gh_app_private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
app_1_id: ${{ secrets.APP_1_ID }}
app_1_private_key: ${{ secrets.APP_1_PRIVATE_KEY }}
app_2_id: ${{ secrets.APP_2_ID }}
app_2_private_key: ${{ secrets.APP_2_PRIVATE_KEY }}



Expand Down
16 changes: 15 additions & 1 deletion .github/workflows/agents-decompose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,22 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.SERVICE_BOT_PAT }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
owner_pr_pat: ${{ secrets.OWNER_PR_PAT }}
agents_automation_pat: ${{ secrets.AGENTS_AUTOMATION_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}
keepalive_app_id: ${{ secrets.KEEPALIVE_APP_ID }}
keepalive_app_private_key: ${{ secrets.KEEPALIVE_APP_PRIVATE_KEY }}
gh_app_id: ${{ secrets.GH_APP_ID }}
gh_app_private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
app_1_id: ${{ secrets.APP_1_ID }}
app_1_private_key: ${{ secrets.APP_1_PRIVATE_KEY }}
app_2_id: ${{ secrets.APP_2_ID }}
app_2_private_key: ${{ secrets.APP_2_PRIVATE_KEY }}



Expand Down
64 changes: 60 additions & 4 deletions .github/workflows/agents-guard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,22 @@ jobs:
steps.api_client_base.outputs.available == 'true'
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.SERVICE_BOT_PAT }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
owner_pr_pat: ${{ secrets.OWNER_PR_PAT }}
agents_automation_pat: ${{ secrets.AGENTS_AUTOMATION_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}
keepalive_app_id: ${{ secrets.KEEPALIVE_APP_ID }}
keepalive_app_private_key: ${{ secrets.KEEPALIVE_APP_PRIVATE_KEY }}
gh_app_id: ${{ secrets.GH_APP_ID }}
gh_app_private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
app_1_id: ${{ secrets.APP_1_ID }}
app_1_private_key: ${{ secrets.APP_1_PRIVATE_KEY }}
app_2_id: ${{ secrets.APP_2_ID }}
app_2_private_key: ${{ secrets.APP_2_PRIVATE_KEY }}

- name: Setup API client (Workflows fallback)
if: >-
Expand All @@ -102,8 +116,22 @@ jobs:
steps.api_client_base.outputs.available != 'true'
uses: "stranske/Workflows/.github/actions/setup-api-client@ebef44a616c1da319b1dc96658978fd8f621a00c" # v1
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.SERVICE_BOT_PAT }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
owner_pr_pat: ${{ secrets.OWNER_PR_PAT }}
agents_automation_pat: ${{ secrets.AGENTS_AUTOMATION_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}
keepalive_app_id: ${{ secrets.KEEPALIVE_APP_ID }}
keepalive_app_private_key: ${{ secrets.KEEPALIVE_APP_PRIVATE_KEY }}
gh_app_id: ${{ secrets.GH_APP_ID }}
gh_app_private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
app_1_id: ${{ secrets.APP_1_ID }}
app_1_private_key: ${{ secrets.APP_1_PRIVATE_KEY }}
app_2_id: ${{ secrets.APP_2_ID }}
app_2_private_key: ${{ secrets.APP_2_PRIVATE_KEY }}

- name: Verify pull_request_target safety invariants
if: >-
Expand Down Expand Up @@ -162,8 +190,22 @@ jobs:
steps.api_client_head.outputs.available == 'true'
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.SERVICE_BOT_PAT }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
owner_pr_pat: ${{ secrets.OWNER_PR_PAT }}
agents_automation_pat: ${{ secrets.AGENTS_AUTOMATION_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}
keepalive_app_id: ${{ secrets.KEEPALIVE_APP_ID }}
keepalive_app_private_key: ${{ secrets.KEEPALIVE_APP_PRIVATE_KEY }}
gh_app_id: ${{ secrets.GH_APP_ID }}
gh_app_private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
app_1_id: ${{ secrets.APP_1_ID }}
app_1_private_key: ${{ secrets.APP_1_PRIVATE_KEY }}
app_2_id: ${{ secrets.APP_2_ID }}
app_2_private_key: ${{ secrets.APP_2_PRIVATE_KEY }}

- name: Setup API client (Workflows fallback)
if: >-
Expand All @@ -172,8 +214,22 @@ jobs:
steps.api_client_head.outputs.available != 'true'
uses: "stranske/Workflows/.github/actions/setup-api-client@ebef44a616c1da319b1dc96658978fd8f621a00c" # v1
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.SERVICE_BOT_PAT }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
owner_pr_pat: ${{ secrets.OWNER_PR_PAT }}
agents_automation_pat: ${{ secrets.AGENTS_AUTOMATION_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}
keepalive_app_id: ${{ secrets.KEEPALIVE_APP_ID }}
keepalive_app_private_key: ${{ secrets.KEEPALIVE_APP_PRIVATE_KEY }}
gh_app_id: ${{ secrets.GH_APP_ID }}
gh_app_private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
app_1_id: ${{ secrets.APP_1_ID }}
app_1_private_key: ${{ secrets.APP_1_PRIVATE_KEY }}
app_2_id: ${{ secrets.APP_2_ID }}
app_2_private_key: ${{ secrets.APP_2_PRIVATE_KEY }}


- name: Evaluate protected file changes
Expand Down
16 changes: 15 additions & 1 deletion .github/workflows/agents-keepalive-dispatch-handler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,22 @@ jobs:
- name: Setup API client
uses: ./.github/actions/setup-api-client
with:
secrets: ${{ toJSON(secrets) }}
# named inputs, not the whole secrets context (see #3185)
github_token: ${{ github.token }}
service_bot_pat: ${{ secrets.SERVICE_BOT_PAT }}
actions_bot_pat: ${{ secrets.ACTIONS_BOT_PAT }}
owner_pr_pat: ${{ secrets.OWNER_PR_PAT }}
agents_automation_pat: ${{ secrets.AGENTS_AUTOMATION_PAT }}
workflows_app_id: ${{ secrets.WORKFLOWS_APP_ID }}
workflows_app_private_key: ${{ secrets.WORKFLOWS_APP_PRIVATE_KEY }}
keepalive_app_id: ${{ secrets.KEEPALIVE_APP_ID }}
keepalive_app_private_key: ${{ secrets.KEEPALIVE_APP_PRIVATE_KEY }}
gh_app_id: ${{ secrets.GH_APP_ID }}
gh_app_private_key: ${{ secrets.GH_APP_PRIVATE_KEY }}
app_1_id: ${{ secrets.APP_1_ID }}
app_1_private_key: ${{ secrets.APP_1_PRIVATE_KEY }}
app_2_id: ${{ secrets.APP_2_ID }}
app_2_private_key: ${{ secrets.APP_2_PRIVATE_KEY }}



Expand Down
Loading
Loading