fix(runner): narrow optional completion state for consumer mypy by stranske · Pull Request #3445 · stranske/Workflows

stranske · 2026-09-14T12:31:31Z

Source: Issue #1836

Related to campaign issue #1836

Automated Status Summary

Scope

Sync/Dependency Campaign Queue

Durable tracker — see docs/ops/DURABLE_TRACKING_ISSUES.md. The body below is regenerated each cycle by maint-82-sync-dependency-campaign.yml; do not close as part of routine triage.

Remote discovery found more review-thread work than fits in a full GitHub issue body. The marker below retains the compact machine-readable queue for the local watcher.

Context for Agent

Related Issues/PRs

Tasks

Acceptance criteria

Acceptance criteria section missing from source issue.

Head SHA: 42eee1e
Latest Runs: ✅ success — Gate
Required: gate: ✅ success

Workflow / Job	Result	Logs
Auto-label dependency PRs	⏭️ skipped	View run
Gate	✅ success	View run
Health 40 Sweep	✅ success	View run
Health 44 Gate Branch Protection	✅ success	View run
Health 45 Agents Guard	✅ success	View run
Health 50 Security Scan	✅ success	View run
Health 52 Semgrep Scan	✅ success	View run
Maint 52 Validate Workflows	✅ success	View run
PR 11 - Minimal invariant CI	✅ success	View run
PR 46 Dependency Repair Contract	⏭️ skipped	View run
Running Copilot Code Review	✅ success	View run
Selftest CI	✅ success	View run

coderabbitai · 2026-09-14T12:31:40Z

Warning

Review limit reached

Next included review available in 48 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 64 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Essentials

Run ID: 9df82bbf-46d3-4bcf-94e3-0b32dfd0d220

📥 Commits

Reviewing files that changed from the base of the PR and between a5908e2 and 42eee1e.

📒 Files selected for processing (2)

scripts/runner_lib/core.py
tests/scripts/test_runner_lib.py

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector · 2026-09-14T12:31:44Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-14T12:33:04.910848Z	`42eee1e`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot

🟢 Approval recommended

The type-check fix and edge-case coverage are complete with no unresolved blocking issues.

Pull request overview

This PR narrows the runner’s optional completion state for mypy while preserving runtime behavior.

Changes:

Replace truthiness checking with an explicit None guard.
Add parameterized tests for productivity-state edge cases.

File summaries

File	Description
`tests/scripts/test_runner_lib.py`	Tests productivity-state variants.
`scripts/runner_lib/core.py`	Narrows optional state before `.get()`.

Review details

Files reviewed: 2/2 changed files
Comments generated: 0
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

stranske-keepalive · 2026-09-14T12:40:54Z

Automated Status Summary

Head SHA: 0face69
Latest Runs: ⏳ pending — Gate
Required contexts: summary
Required: core tests (3.12): ⏳ pending, core tests (3.13): ⏳ pending, docker smoke: ⏳ pending, gate: ⏳ pending

Workflow / Job	Result	Logs
(no jobs reported)	⏳ pending	—

Coverage Overview

Coverage history entries: 1

Coverage Trend

Metric	Value
Current	80.05%
Baseline	85.00%
Delta	-4.95%
Minimum	70.00%
Status	✅ Pass

Top Coverage Hotspots (lowest coverage)

File	Coverage	Missing
`scripts/issue_dedup_smoke.py`	0.0%	4
`scripts/runner_lib/__main__.py`	0.0%	3
`scripts/prune_agent_stubs.py`	39.7%	26
`tools/ensure_workflow_timeout_variables.py`	42.1%	74
`scripts/repo_review_round2_runner.py`	42.6%	344
`scripts/sync_label_docs.py`	42.9%	64
`scripts/repo_review_backlog_scan.py`	45.3%	116
`tools/codex_session_analyzer.py`	47.9%	59
`scripts/create_verifier_labels.py`	48.3%	58
`tools/ci_failure_triage.py`	49.7%	113
`scripts/validate_template_sync.py`	52.1%	36
`scripts/select_consumer_sync_phase.py`	53.0%	62
`scripts/langchain/verdict_extract.py`	54.1%	21
`scripts/langsmith_observability_health.py`	55.3%	83
`scripts/analyze_codex_session.py`	59.2%	74

Low Coverage Files (<50.0%)

File	Coverage	Missing
`scripts/issue_dedup_smoke.py`	0.0%	4
`scripts/runner_lib/__main__.py`	0.0%	3
`scripts/prune_agent_stubs.py`	39.7%	26
`tools/ensure_workflow_timeout_variables.py`	42.1%	74
`scripts/repo_review_round2_runner.py`	42.6%	344
`scripts/sync_label_docs.py`	42.9%	64
`scripts/repo_review_backlog_scan.py`	45.3%	116
`tools/codex_session_analyzer.py`	47.9%	59
`scripts/create_verifier_labels.py`	48.3%	58
`tools/ci_failure_triage.py`	49.7%	113

Updated automatically; will refresh on subsequent CI/Docker completions.

Keepalive checklist

Scope

No scope information available

Tasks

No tasks defined

Acceptance criteria

No acceptance criteria defined

fix(runner): narrow optional completion state for consumer mypy

42eee1e

Copilot AI lite review requested due to automatic review settings September 14, 2026 12:31

stranske deployed to agent-standard September 14, 2026 12:31 — with GitHub Actions Active

Copilot started reviewing on behalf of stranske September 14, 2026 12:32 View session

Copilot AI reviewed Sep 14, 2026

View reviewed changes

stranske merged commit 3706dc2 into main Sep 14, 2026
56 checks passed

stranske deleted the codex/sync-runner-optional-state-20260914 branch September 14, 2026 14:28

Navigation Menu

fix(runner): narrow optional completion state for consumer mypy - #3445

fix(runner): narrow optional completion state for consumer mypy#3445
stranske merged 1 commit into
mainfrom
codex/sync-runner-optional-state-20260914

stranske commented Sep 14, 2026 •

edited by stranske-keepalive Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 14, 2026

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Sep 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

stranske-keepalive Bot commented Sep 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

stranske commented Sep 14, 2026 • edited by stranske-keepalive Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automated Status Summary

Scope

Sync/Dependency Campaign Queue

Context for Agent

Related Issues/PRs

Tasks

Acceptance criteria

Uh oh!

coderabbitai Bot commented Sep 14, 2026

Review limit reached

Uh oh!

chatgpt-codex-connector Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

stranske-keepalive Bot commented Sep 14, 2026

Automated Status Summary

Coverage Overview

Coverage Trend

Top Coverage Hotspots (lowest coverage)

Low Coverage Files (<50.0%)

Keepalive checklist

Scope

Tasks

Acceptance criteria

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

stranske commented Sep 14, 2026 •

edited by stranske-keepalive Bot

Loading

chatgpt-codex-connector Bot commented Sep 14, 2026 •

edited

Loading