Skip to content

fix: address bot review comments from sync PRs #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stranske merged 1 commit into from
Jan 5, 2026
Merged

fix: address bot review comments from sync PRs #536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/scripts/agents-guard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,9 @@ function evaluateGuard({
const hasCodeownerApproval = hasExternalApproval || authorIsCodeowner;

const hasProtectedChanges = modifiedProtectedPaths.size > 0;
// Allow label to bypass approval for automated PRs (dependabot, renovate)
// Security note: Allow `agents:allow-change` label to bypass CODEOWNER approval
// ONLY for automated dependency PRs from known bots (dependabot, renovate).
// Human PRs or other bot PRs still require CODEOWNER approval even with label.
const isAutomatedPR = normalizedAuthor && (normalizedAuthor === 'dependabot[bot]' || normalizedAuthor === 'renovate[bot]');
const needsApproval = hasProtectedChanges && !hasCodeownerApproval && !(hasAllowLabel && isAutomatedPR);
const needsLabel = hasProtectedChanges && !hasAllowLabel && !hasCodeownerApproval;
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/keepalive_loop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1089,7 +1089,7 @@ async function evaluateKeepaliveLoop({ github, context, core, payload: overrideP
let action = 'wait';
let reason = 'pending';
const verificationStatus = normalise(state?.verification?.status);
Comment thread
stranske marked this conversation as resolved.
const verificationDone = ['done', 'verified', 'complete'].includes(verificationStatus.toLowerCase());
const verificationDone = ['done', 'verified', 'complete'].includes(verificationStatus);
const needsVerification = allComplete && !verificationDone;

if (!hasAgentLabel) {
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/keepalive_prompt_routing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const FEATURE_SCENARIOS = new Set([
'nexttask',
]);

const FIX_MODES = new Set(['fix', 'fix-ci', 'fix_ci', 'ci', 'ci-failure']);
const FIX_MODES = new Set(['fix', 'fix-ci', 'fix_ci', 'ci', 'ci-failure', 'ci_failure', 'fix-ci-failure']);
const VERIFY_MODES = new Set(['verify', 'verification', 'verify-acceptance', 'acceptance']);

function resolvePromptMode({ scenario, mode, action, reason } = {}) {
Expand Down
Loading