Skip to content

Specify --dev dependency for loopdev-3 - #10

Merged
mulkieran merged 1 commit into
stratis-storage:masterfrom
mulkieran:dev-for-loopdev-3
Oct 13, 2025
Merged

Specify --dev dependency for loopdev-3#10
mulkieran merged 1 commit into
stratis-storage:masterfrom
mulkieran:dev-for-loopdev-3

Conversation

@mulkieran

@mulkieranmulkieran commented Oct 13, 2025

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitaiBot commented Oct 13, 2025

Copy link
Copy Markdown

Walkthrough

The GitHub Action in stratisd-modify/action.yml now accepts a per-dependency flag via a new DEPENDENCY_TYPE array. The loop reads each dependency’s type (e.g., --build, --dev) and passes it to cargo add along with the git URL and branch; duplicate checks, error handling, and the final cargo tree remain unchanged.

Changes

Cohort / File(s)Summary
GitHub Action: dependency handling
stratisd-modify/action.yml
Added DEPENDENCY_TYPE array; loop reads per-item flag and invokes cargo add $dependency $dependency_type --git https://github.com/<owner>/$repo --branch $GITHUB_HEAD_REF. Control flow branches per item on dependency_type; duplicate-checks, error handling, and final cargo tree are preserved.

Sequence Diagram(s)

sequenceDiagram
autonumber
actor Runner
participant Action as Action Script
participant Cargo as cargo
participant Remote as Remote Git
Runner->>Action: start
Action->>Action: iterate dependencies
alt dependency_type present
Action->>Cargo: cargo add <dep> <dependency_type> --git <url> --branch <branch>
else dependency_type empty
Action->>Cargo: cargo add <dep> --git <url> --branch <branch>
end
Cargo->>Remote: fetch repo/branch
Remote-->>Cargo: repo data
Cargo-->>Action: added/duplicate/error
Action->>Cargo: cargo tree
Cargo-->>Action: dependency tree output
Action-->>Runner: finish
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop through deps with flags in tow,
Per-crate I whisper: build, dev — go!
Branches fetched, duplicates checked right,
Cargo tree blooms into sight.
Tiny paws, tidy code tonight. 🐇📦

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title Check✅ PassedThe title succinctly describes the primary change of adding a --dev flag for the loopdev-3 dependency, clearly reflecting the update to the per-dependency cargo add logic without unrelated or vague wording.
Docstring Coverage✅ PassedNo functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd37d85 and 59c242e.

📒 Files selected for processing (1)
  • stratisd-modify/action.yml (1 hunks)
🔇 Additional comments (1)
stratisd-modify/action.yml (1)

21-30: Loopdev flagged correctly as a dev dependency

Only loopdev-3 now carries the --dev flag while the runtime crates stay with the default section, so cargo add keeps them under [dependencies] and the previous build-dependency regression is avoided. Looks good.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mulkieranmulkieran moved this to In Progress in 2025OctoberOct 13, 2025

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 802c951 and dd37d85.

📒 Files selected for processing (1)
  • stratisd-modify/action.yml (1 hunks)

Comment threadstratisd-modify/action.yml Outdated
Otherwise, cargo-add adds loopdev-3 as a regular source dependency, rather
than overwriting the existing dev dependency specification.
Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
mulkieran merged commit 343711f into stratis-storage:masterOct 13, 2025
2 checks passed
@github-project-automationgithub-project-automationBot moved this from In Progress to Done in 2025OctoberOct 13, 2025
@mulkieran
mulkieran deleted the dev-for-loopdev-3 branch October 13, 2025 15:24
@mulkieranmulkieran moved this from Done to Done(2) in 2025OctoberOct 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done(2)

Development

Successfully merging this pull request may close these issues.

1 participant

@mulkieran