Uh oh!
There was an error while loading. Please reload this page.
Sync OxiaCluster CRD - #115
Merged
Merged
Conversation
labuladong
approved these changes
Sep 7, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The CRD schema update is consistent with existing patterns in other CRDs and is structurally sound with no identified correctness issues.
Pull request overview
This PR syncs the OxiaCluster CRD schema to include configuration for operator-managed Kubernetes API objects, specifically a PodDisruptionBudget (PDB), aligning Oxia’s CRD capabilities with other StreamNative CRDs that already expose similar knobs.
Changes:
- Adds
spec.apiObjects.pdbto the OxiaCluster CRD schema. - Exposes PDB management flags and fields (
managed,minAvailable/maxUnavailable,metadata.{labels,annotations,name},updatePolicy) for customization via the CRD.
File summaries
| File | Description |
|---|---|
| charts/sn-operator/crds/k8s.streamnative.io_oxiaclusters.yaml | Extends the OxiaCluster CRD OpenAPI schema with spec.apiObjects.pdb configuration. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.