Skip to content

Track status changes, voice status changes, and games (activities) - #51

Open
emmiegit wants to merge 24 commits into
masterfrom
status-changes
Open

Track status changes, voice status changes, and games (activities)#51
emmiegit wants to merge 24 commits into
masterfrom
status-changes

Conversation

@emmiegit

@emmiegitemmiegit commented Apr 4, 2018

Copy link
Copy Markdown
Collaborator

Updates the old branch to use the new concept of the "activity", and properly handle status changes and activity updates.

@emmiegit
emmiegit requested a review from robstolarzApril 4, 2018 00:12
jchristgit
jchristgit reviewed Apr 13, 2018
View reviewed changes
Comment threadstatbot/status.py Outdated
@emmiegitemmiegit changed the title Track status changes and gamesTrack status changes, voice status changes, and games (activities)Apr 14, 2018
@emmiegit

emmiegit commented Apr 14, 2018

Copy link
Copy Markdown
CollaboratorAuthor

Added tracking for voice status changes.

jchristgit
jchristgit reviewed Apr 14, 2018
View reviewed changes

@jchristgitjchristgit left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still don't fully know what this thing does, tales tell that it's some mini-facebook thing for discord. haven't found much to "review", i don't know why you asked me to, but since you asked for it, here's a bunch of useless review comments

Comment threadstatbot/sql.py
Comment threadstatbot/sql.py
Comment threadstatbot/sql.py
Comment threadstatbot/sql.py
Comment threadstatbot/sql.py
Comment threadstatbot/sql.py Outdated
Comment threadstatbot/status.py
emmiegit added 24 commits June 5, 2018 15:31
@emmiegit
Add schema changes for status and game.
54c6d0b
@emmiegit
Hook in events for status and game changes.
dd590cd
@emmiegit
Fix SQL name conflict.
300f6c0
@emmiegit
Add game and status it _init_sql()
e72d793
@emmiegit
Fix bug in remove_all_members().
b3ee9d2
@emmiegit
Fix constraint in special insertion.
660a9da
@emmiegit
Add schema changes for status and game.
e433b24
@emmiegit
Fix SQL name conflict.
bdfcb11
@emmiegit
Add schema changes for status and game.
02382b6
@emmiegit
Fix SQL name conflict.
dd2b464
@emmiegit
Fix bug in remove_all_members().
85b108f
@emmiegit
Add schema changes for status and game.
0601369
@emmiegit
Hook in events for status and game changes.
508ed5e
@emmiegit
Fix SQL name conflict.
d8475cf
@emmiegit
Add game and status it _init_sql()
4b6cad7
@emmiegit
Rename 'status' column to avoid conflict.
51f0122
@emmiegit
Add UserStatus enum.
5d3bd67
@emmiegit
Running fixes.
eb8212e
@emmiegit
Only add fields to JSON if they exist.
925754f
@emmiegit
Other update improvements.
3b182ee
@emmiegit
Use constant dictionary for UserStatus conversion.
89efb35
@emmiegit
Fix pylint issue.
6e29251
@emmiegit
Add tracking for voice event changes.
a5c6978
@emmiegit
Use with_only_columns() to restrict SELECT.
2e4b2e3
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raylurayluraylu left review comments
@robstolarzrobstolarzAwaiting requested review from robstolarz
+1 more reviewer
@jchristgitjchristgitjchristgit left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emmiegit@raylu@jchristgit