Skip to content
This repository was archived by the owner on May 29, 2019. It is now read-only.

Drop peer dependency on loopback - #14

Merged
bajtos merged 1 commit into
masterfrom
feature/drop-loopback-peer-dep
Jun 12, 2014
Merged

Drop peer dependency on loopback#14
bajtos merged 1 commit into
masterfrom
feature/drop-loopback-peer-dep

Conversation

@bajtos

Copy link
Copy Markdown
Contributor

The peer dependency was used to control which loopback versions
we are compatible with. Unfortunately it does not work well, e.g.
even when the peer dep allows loopback 2.x, npm installs 1.x version
instead.

/to @ritch please review

The peer dependency was used to control which loopback versions
we are compatible with. Unfortunately it does not work well, e.g.
even when the peer dep allows loopback 2.x, npm installs 1.x version
instead.
@ritch

Copy link
Copy Markdown
Contributor

This will potentially bite users. For example #15 might end up requiring changes in loopback that break compatibility with older versions of this module. The only way to find that out is will be really odd - hard to catch bugs in your tests.

What if we just wrote a simple version check like this:

varpkg=require('./package.json');varloopbackPkg=require('loopback/package.json');varisCompatible=semver.satisfies(loopbackPkg.version,pkg.loopbackVersion);if(!isCompatible){thrownewError('incompatible loopback version');}

Either way, I am all for removing this as it has probably hurt more than helped.

👍

bajtos added a commit that referenced this pull request Jun 12, 2014
@bajtos
bajtos merged commit 25be2d7 into masterJun 12, 2014
@bajtos

Copy link
Copy Markdown
ContributorAuthor

Let's move the discussion to #18.

@bajtos
bajtos deleted the feature/drop-loopback-peer-dep branch June 12, 2014 08:13
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bajtos@ritch