Uh oh!
There was an error while loading. Please reload this page.
Allow another name convention for User model and AccessToken model - #26
Allow another name convention for User model and AccessToken model#26clark0x wants to merge 1 commit into
Conversation
slnode
commented
Aug 18, 2014
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
bajtos
commented
Sep 17, 2014
@ritch could you please review and land? I did a superficial review and did not find any issues, but you know the code better than I do. |
ritch
commented
Sep 18, 2014
ok to test |
guanbo
commented
Sep 23, 2014
@clarkorz, can you recommit and make @ritch merge into master. I have same problem. thanks! |
clark0x
commented
Dec 9, 2014
@ritch I have switched to a more simpler approach. Could you review again? |
There was a problem hiding this comment.
@justin-lauthis doesn't point to the test object. 'AccessToken' is the key of options, it will be use to retrieve the configured model name in _beforeEach#givenModel().
zero5100
commented
Mar 17, 2015
Could someone resolve this please? I use a different naming convention for the model overrides in my application. |
If project doesn't extend built-in models **User** and **AccessToken** as **user** and **accessToken**, `givenModel()` can NOT find these models by keys `user` and `accessToken` via `app.models[key]`. By capitalizing the keys, `givenModel()` can always find the proper built-in model. Note: When `user` model extends `User` model, it will register both `user` and `User` to `app.models`. Signed-off-by: Clark Wang <clark.wangs@gmail.com> Allow to specify user and accessToken models Add an options param to `lt.beforeEach.withApp()`, allow to specify the user model and/or accessToken model that will be used in the tests. Signed-off-by: Clark Wang <clark.wangs@gmail.com> refactor according to @ritch's notes Signed-off-by: Clark Wang <clark.wangs@gmail.com> use a simple approach Signed-off-by: Clark Wang <clark.wangs@gmail.com> remove unused dep Signed-off-by: Clark Wang <clark.wangs@gmail.com> pass tests Signed-off-by: Clark Wang <clark.wangs@gmail.com> fix missing dep upgrade to use lodash string util methods Signed-off-by: Clark Wang <clark.wangs@gmail.com>
8a472d8 to
63a1727Compareclark0x
commented
Mar 18, 2015
@ritch could you please review and land? |
zero5100
commented
Mar 18, 2015
roleMapping is also referenced by name on line 141 and 143. It would be nice if the model names loopback-testing uses could be overridden at runtime when importing the module. I might fork this later and implement something like that to get this working for me without needing the extra model extensions. |
zero5100
commented
Jun 17, 2015
See #57 for a potential fix for this. |
If project doesn't extend built-in models User and
AccessToken as user and accessToken,
givenModel()can NOT find these models by keys
userandaccessTokenviaapp.models[key].By classify the modelName,
givenModel()can always find theproper built-in model.
Note: When
usermodel extendsUsermodel, it will registerboth
userandUsertoapp.models.FYI: This doesn't fix the case of extending User model withother name (e.g. Account), and AccessToken also.
Signed-off-by: Clark Wang clark.wangs@gmail.com