Uh oh!
There was an error while loading. Please reload this page.
Add phase at position - #5
Merged
Merged
Conversation
added 2 commits
November 11, 2014 14:27
Refactor `var phaseList = new PhaseList()` into a test-global variable.
Implement the following methods for adding new phases at a given position: - `phases.addAt(index, phase)` - `phases.addBefore(name, phase)` - `phases.addAfter(name, phase)`
Throw an error when a phase with an existing name is added again.
bajtos
commented
Nov 11, 2014
MemberAuthor
Added one more commit - "prevent re-adding of existing phase" |
raymondfeng
commented
Nov 11, 2014
Member
LGTM |
ritch
commented
Nov 11, 2014
Member
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the following methods for adding new phases at a given
position:
phases.addAt(index, phase)phases.addBefore(name, phase)phases.addAfter(name, phase)The first commit cleans up the unit tests.
/to @ritch please review