Uh oh!
There was an error while loading. Please reload this page.
Add strongErrorHandler templates - #284
Closed
loay wants to merge 1 commit into
Closed
Conversation
loay
commented
Jun 7, 2016
ContributorAuthor
@bajtos PTAL |
| "errorHandler": { | ||
| "disableStackTrace": false | ||
| "strong-error-handler": { | ||
| "isDebugMode": false |
Member
There was a problem hiding this comment.
I believe the errorhandler section of remoting config was not changed, pelase revert.
@davidcheung could you please confirm?
There was a problem hiding this comment.
this is for strong-remoting, I think keeping it as errorHandler might be easiest for users
https://github.com/strongloop/strong-remoting/blob/b03dfe8ec53d4ca694a2e438d6b5dadff0824305/lib/rest-adapter.js#L316
"errorHandler" : {"debug": true,"log": false}bajtos
commented
Jun 7, 2016
Member
@loay also check why CI is failing. |
loay
commented
Jun 7, 2016
ContributorAuthor
@bajtos I fixed the above mentioned issue. I will add the test case now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.