Skip to content

Add strong-error-handler to project templates - #292

Merged
loay merged 1 commit into
masterfrom
errorTemplate
Jun 23, 2016
Merged

Add strong-error-handler to project templates#292
loay merged 1 commit into
masterfrom
errorTemplate

Conversation

@loay

@loayloay commented Jun 23, 2016

Copy link
Copy Markdown
Contributor

connect to strongloop-internal/scrum-loopback#896
connect to strongloop/loopback-boot#193
reference for previous discussion: #285

@loay

loay commented Jun 23, 2016

Copy link
Copy Markdown
ContributorAuthor

@bajtos PTAL

Comment threadtest/end-to-end.js Outdated
});
});

it('includes sensitive error details in development mode', function(done) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two tests should live inside describe('end-to-end') block, since they are relying on SANDBOX being initialised with an app.

@bajtos

Copy link
Copy Markdown
Member

LGTM

@bajtosbajtos removed their assignment Jun 23, 2016
@bajtosbajtos changed the title update errorhandler templatesAdd strong-error-handler to project templatesJun 23, 2016
@loay
loay merged commit 739d20f into masterJun 23, 2016
@loay
loay deleted the errorTemplate branch June 23, 2016 12:58
@loayloay removed the #review label Jun 23, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@loay@bajtos