Promisify User model

[PradnyaBaviskar]

Connect #418

[PradnyaBaviskar]

For this test, User.login throws "Unhandled rejection Error: login failed". And so, when executing the test it says "Cannot call method 'then' of undefined". Whereas, https://github.com/strongloop/loopback/pull/1493/files#diff-5d81af95449574544e7317f3eda2badeR259, correctly returns fn.promise

@bajtos - can you help me?

[pulkitsinghal]

@PradnyaBaviskar It would seem that the loopback team intentionally limited the promisification to CRUD methods

@pulkitsinghal wrote: So the CRUD methods for models and relatedModels now use promises ... but something like User.login() still does not ... correct?

@bajtos wrote: Yes, that's a correct description of the current status.

But that doesn't mean we shouldn't get the other ones also promisified, thanks for opening this, +1

[bajtos]

Where is the app variable defined? Perhaps this is throwing an error that is later converted to the error message you are seeing?

[bajtos]

Oh, are you relying on the fact that test/support.js is setting up a global app variable?

[PradnyaBaviskar]

Done with promisifying User model.

@raymondfeng, can you please review?
/cc @bajtos

[bajtos]

@slnode test please

[bajtos]

Landed, thank you for the contribution!

[bajtos]

FWIW, the Jenkins build is failing due to an issue that was fixed on master by 34eb0e1