Uh oh!
There was an error while loading. Please reload this page.
Remove constraint making isStatic required - #2174
Conversation
| key = isStatic ? key : m[1]; | ||
| meta.isStatic = isStatic; | ||
| } else { | ||
| if (meta.isStatic && m) { |
There was a problem hiding this comment.
Nitpick: the new block {...} starting on L268 is not necessary, it adds extraneous nesting. Here is a version that I consider cleaner:
if(typeofmeta.isStatic!=='boolean'){// ...}elseif(meta.isStatic&&m){// ...}else{// ...}bajtos
commented
Mar 29, 2016
@0candy one more thing, please add an entry to 3.0-RELEASE-NOTES. |
| 'prototype.instanceMethod': { | ||
| http: { path: '/instance' } | ||
| } | ||
| ``` No newline at end of file |
There was a problem hiding this comment.
Please add a link to this pull request, to make it easier for readers to look up discussions that led to this change. AFAICT, other entries include a link to the relevant pull request too.
bajtos
commented
Mar 30, 2016
@0candy one last comment to address. When you fix it, please squash the commits and land the patch, no need for more reviews. Some of the CI builds are failing, please check that these failures are not caused by your change. |
bajtos
commented
Mar 30, 2016
The Travis build is failing because we haven't released a new juggler version with loopbackio/loopback-datasource-juggler@0d11186. We are withholding 2.x releases until @Amir-61 finishes his work on replaceOrCreate feature, to ensure we won't need to change the implementation that is already there in a backwards-incompatible way. |
7bba791 to
6157a3dCompare6157a3d to
b5b900eCompare
Connect to: https://github.com/strongloop-internal/scrum-loopback/issues/617