Uh oh!
There was an error while loading. Please reload this page.
[SEMVER-MAJOR] Removed unused user properties - #2299
Merged
Conversation
davidcheung
commented
May 5, 2016
ContributorAuthor
@slnode test please |
| Please see [related code change](https://github.com/strongloop/loopback/pull/2174) here. No newline at end of file | ||
| Please see [related code change](https://github.com/strongloop/loopback/pull/2174) here. | ||
| ## Removing unused user properties |
Member
There was a problem hiding this comment.
We use imperative on L23, pleas do the same for consistency.
## Remove unused user properties
davidcheung
commented
May 9, 2016
ContributorAuthor
Updated the description |
| Developers that are relying on these properties, can redefine them in `user.json` or equivalent model.json as follow: | ||
| ```js | ||
| //user.json | ||
| "credentials": { |
Member
There was a problem hiding this comment.
Please start at the top level of model JSON file to make it more clear where to add this snippet. Also use json for highlighting (you can check the source of my comment to see how to do it in markdown):
{
"name": "MyUser",
"base": "User",
"properties": {
"credentials": { "type": "object" },
"challenges": { "type": "object" },
"status": "string",
"created": "date",
"lastUpdated": "date"
}
} bajtos
commented
May 9, 2016
Member
Two more comments, the PR looks good otherwise. No further review is necessary, please squash the commits before landing (and rebase on top of the current master). |
davidcheungforce-pushed
the
removed-unused-user-properties
branch
2 times, most recently
from
May 10, 2016 18:27
6dc2bd8 to
42c3b38Compare
- credentials - challenges - status - created - lastUpdated
davidcheungforce-pushed
the
removed-unused-user-properties
branch
from
May 10, 2016 18:29
42c3b38 to
817e76eCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
connect to #1854
Removed properties