Uh oh!
There was an error while loading. Please reload this page.
Remove Change.handleError - #2308
Merged
Merged
Conversation
0candyforce-pushed
the
remove_change_handleError
branch
2 times, most recently
from
May 6, 2016 17:34
3f5d146 to
31390f6Compare| Please see [related code change](https://github.com/strongloop/loopback/pull/2174) here. No newline at end of file | ||
| Please see [related code change](https://github.com/strongloop/loopback/pull/2174) here. | ||
| ## removing `Change.handleError` |
Member
There was a problem hiding this comment.
Please use imperative as we already use elsewhere, i.e.
## remove `Change.handleError`
bajtos
commented
May 9, 2016
Member
One issue to address, the rest LGTM. No further reviews are necessary. |
0candyforce-pushed
the
remove_change_handleError
branch
from
May 9, 2016 15:45
31390f6 to
8ab6fccCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connect to https://github.com/strongloop-internal/scrum-loopback/issues/768