Uh oh!
There was an error while loading. Please reload this page.
[SEMVER-MAJOR] Remove legacy express 3.x middleware getters - #2394
Merged
Conversation
bajtosforce-pushed
the
remove-express-middleware
branch
from
May 31, 2016 15:00
870bddb to
fd49086Comparebajtos
commented
May 31, 2016
MemberAuthor
@slnode test please |
raymondfeng
commented
May 31, 2016
Member
LGTM |
bajtos added a commit
that referenced
this pull request
May 31, 2016
In LoopBack 3.0, we are removing these getters, see #2394.
bajtos added a commit
that referenced
this pull request
May 31, 2016
In LoopBack 3.0, we are removing these getters, see #2394.
Remove middleware-getter properties that were simlifying upgrade from LoopBack 1.x/Express 3.x applications: - loopback.compress - loopback.timeout - loopback.cookieParser - loopback.cookieSession - loopback.csrf - loopback.errorHandler - loopback.session - loopback.methodOverride - loopback.logger - loopback.responseTime - loopback.favicon - loopback.directory - loopback.vhost Also remove `loopback.mime`, which was set to `undefined` anyways.
bajtosforce-pushed
the
remove-express-middleware
branch
from
May 31, 2016 16:59
fd49086 to
8d295b7Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove middleware-getter properties that were simlifying upgrade from
LoopBack 1.x/Express 3.x applications:
Also remove
loopback.mime, which was set toundefinedanyways.@raymondfeng please review