Uh oh!
There was an error while loading. Please reload this page.
[SEMVER-MAJOR] Remove current-context API - #2564
Merged
Merged
Conversation
bajtosforce-pushed
the
feature/remove-current-context
branch
from
July 29, 2016 12:40
8440523 to
48204c0Compare
This was referenced Jul 29, 2016
raymondfeng
commented
Jul 29, 2016
Member
LGTM |
bajtos
commented
Aug 1, 2016
MemberAuthor
@slnode test please |
bajtos
commented
Aug 9, 2016
MemberAuthor
I am waiting for https://github.com/strongloop/loopback-context/pull/3/files before landing this PR. |
bajtosforce-pushed
the
feature/remove-current-context
branch
from
August 10, 2016 11:40
48204c0 to
7ea5b91CompareChange all current-context APIs to throw a helpful error.
bajtosforce-pushed
the
feature/remove-current-context
branch
from
August 10, 2016 11:44
7ea5b91 to
59a82a9Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change all current-context APIs to throw a helpful error.
This is a follow-up for strongloop/loopback-context#1
See also #2559 which deprecates current-context API in 2.x.
@raymondfeng@ritch please review
cc @strongloop/loopback-dev FYI