Uh oh!
There was an error while loading. Please reload this page.
Add partial update test case - #2795
Conversation
loay
commented
Sep 27, 2016
@bajtos PTAL. Thanks. |
bajtos
left a comment
There was a problem hiding this comment.
Looks mostly good, please improve the test name per my comment above, squash the commits into a single one and provide a descriptive commit message.
| ], done); | ||
| }); | ||
| it('keeps sessions AS IS if partial update is done with age', function(done) { |
There was a problem hiding this comment.
Please move the test closer to existing keeps sessions AS IS tests and rename it to mention updateAll, e.g. keeps sessions AS IS if non-email property is changed using updateAll.
c5e6e41 to
cd803caCompareloay
commented
Sep 29, 2016
test please |
1 similar comment
loay
commented
Sep 29, 2016
test please |
loay
commented
Sep 30, 2016
@bajtos PTAL Thanks |
bajtos
left a comment
There was a problem hiding this comment.
One nitpick, the rest LGTM. No further review is needed.
| async.series([ | ||
| function createPartialUser(next) { | ||
| User.create( | ||
| { email: 'partial@example.com', password: 'pass1', age: 25 }, |
There was a problem hiding this comment.
Nitpick: use two spaces for indentation. I am surprised eslint is not complaining.
No description provided.