Uh oh!
There was an error while loading. Please reload this page.
Allow hash path in redirectUrl - #3035
Closed
ambrt wants to merge 1 commit into
Closed
Conversation
slnode
commented
Dec 16, 2016
Can one of the admins verify this patch? |
3 similar comments
slnode
commented
Dec 16, 2016
Can one of the admins verify this patch? |
slnode
commented
Dec 16, 2016
Can one of the admins verify this patch? |
slnode
commented
Dec 16, 2016
Can one of the admins verify this patch? |
bajtos
suggested changes
Dec 21, 2016
| return next(new Error(g.f('The transport does not support HTTP redirects.'))); | ||
| } | ||
| ctx.res.location(ctx.args.redirect); | ||
| ctx.res.location(decodeURIComponent(ctx.args.redirect)); |
Member
There was a problem hiding this comment.
I believe ctx.args.redirect should have been already url-decoded by strong-remoting, therefore this change is not necessary. Unless I am missing something?
ContributorAuthor
There was a problem hiding this comment.
If its decoded then this change is not necessary.
2 tasks
bajtos
commented
Feb 6, 2017
Member
Closing in favour of #3185. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows GET variables and hash paths for redirecting user after email confirm.
Related issues