Uh oh!
There was an error while loading. Please reload this page.
Update user.js - #3132
Conversation
if no token provided for logout, then we set tokenID to empty string to throw a normal error "Error: access_token is a required argument" instead of "Error: Value is not a string"
slnode
commented
Jan 24, 2017
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
slnode
commented
Jan 24, 2017
Can one of the admins verify this patch? |
3 similar comments
slnode
commented
Jan 24, 2017
Can one of the admins verify this patch? |
slnode
commented
Jan 24, 2017
Can one of the admins verify this patch? |
slnode
commented
Jan 24, 2017
Can one of the admins verify this patch? |
loay
commented
Jan 24, 2017
Hi @raeef-refai |
raeef-refai
commented
Jan 24, 2017
excuse me? really? |
raymondfeng
commented
Jan 24, 2017
@raeef-refai You can do it by one click at https://cla.strongloop.com/agreements/strongloop/loopback. Signing CLA is to ensure LoopBack open source with clean IP. |
raeef-refai
commented
Jan 24, 2017
excuse me, I didn't wait from you where should I click. |
raymondfeng
commented
Jan 24, 2017
@raeef-refai We appreciate your contribution but CLA is required to accept the PR. Do you have any concern about signing the CLA? AFAIK, it's a common practice for many open source projects, including those by Apache Software Foundation. The status checks show that you have signed the CLA. If that's by your intention, it's great and we'll be happy to continue the PR process. Otherwise, please close the PR to withdraw. |
bajtos
commented
Jan 25, 2017
Hi @raeef-refai, thank you for pointing out the problem and submitting a fix. I think this issue may be better fixed at strong-remoting level (when a requires string argument is not present, strong-remoting should report "missing argument" instead of "value is not a string" error). I'll take a closer look later this week. |
raeef-refai
commented
Jan 25, 2017
Ok, thank you |
bajtos
commented
Jan 26, 2017
Related: #1496 |
Description
if no token provided for logout, then we set tokenID to empty string to throw a normal error "Error: access_token is a required argument" instead of "Error: Value is not a string"