Skip to content

Check max password length in User.changePassword - #3312

Merged
bajtos merged 1 commit into
masterfrom
fix/change-password-validation
Mar 28, 2017
Merged

Check max password length in User.changePassword#3312
bajtos merged 1 commit into
masterfrom
fix/change-password-validation

Conversation

@bajtos

Copy link
Copy Markdown
Member

Description

The new changePassword API implemented by #3299 was not checking the maximum allowed password length, as added by #2580.

This patch fixes changePassword to validate the password before making the change.

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@bajtosbajtos added this to the Sprint 32 milestone Mar 27, 2017
@bajtosbajtos self-assigned this Mar 27, 2017
Comment threadtest/user.test.js Outdated

// workaround for chai problem
// object tested must be an array, an object, or a string,
// but error given

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird indentation

@bajtos
bajtosforce-pushed the fix/change-password-validation branch from f8cc4ec to b550cdcCompareMarch 28, 2017 13:46
@bajtos
bajtos merged commit f736da6 into masterMar 28, 2017
@bajtos
bajtos deleted the fix/change-password-validation branch March 28, 2017 13:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bajtos@superkhau