Skip to content

Expose more loopback middleware for require#834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raymondfeng merged 1 commit into from
Nov 19, 2014
Merged

Expose more loopback middleware for require #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/express-middleware.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
var express = require('express');
var path = require('path');

var middlewares = exports;
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,6 +46,7 @@
"nodemailer": "~1.3.0",
"nodemailer-stub-transport": "~0.1.4",
"path-to-regexp": "^1.0.1",
"serve-favicon": "^2.1.6",
"strong-remoting": "^2.4.0",
"uid2": "0.0.3",
"underscore": "~1.7.0",
Expand Down
1 change: 1 addition & 0 deletions server/middleware/favicon.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
module.exports = require('../../lib/express-middleware').favicon;

@bajtosbajtosNov 19, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

favicon is different from errorhandler because loopback adds a default favicon file. I can't think of a better way how to provide the default favicon, thus we have to expose the middleware this way.

Few things to consider:

  • Should the file be called loopback/middlewarwe/serve-favicon.js? That is more consistent with serve-favicon.
  • The usual practice is to put the meat of the implementation in the per-feature file (favicon.js) and keep the index file (express-middleware.js) just a lightweight aggregator. We already have a mechanism in place that loads all middleware from server/middleware/*.js. Can you move all of favicon implementation to this new file?

@raymondfengraymondfengNov 19, 2014

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm following the same pattern as static.

See my comment at strongloop/loopback-boot#70 (comment). If it's agreed, we can simply reference it as loopback#favicon without adding extra JS files.

@bajtosbajtosNov 19, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's agreed, we can simply reference it as loopback#favicon without adding extra JS files.

The current way of exposing the middleware via safeRequire is subtly broken - see #833.

While I can see that referencing exported middleware may make sense in general sense, I think it is a bad solution in this particular case. Unless we add serve-favicon to loopback's dependencies.