Skip to content

Refactor to the code use wrapper classes - #94

Merged
raymondfeng merged 2 commits into
masterfrom
feature/access-context
Dec 12, 2013
Merged

Refactor to the code use wrapper classes#94
raymondfeng merged 2 commits into
masterfrom
feature/access-context

Conversation

@raymondfeng

Copy link
Copy Markdown
Member

/to @ritch

Add AccessContext, Principal, and AccessRequest
Add debug information

Add AccessContext, Principal, and AccessRequest
Add debug information
@slnode

Copy link
Copy Markdown

Test PASSed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback/501/

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to differentiate from property and method.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find a better name to capture property/method/relation? In JS, all these things are properties for the instance/class.

@slnode

Copy link
Copy Markdown

Test PASSed. To trigger a build add comment - ".test\W+please"
Refer to this link for build results: http://ci.strongloop.com/job/loopback/502/

@ritch

Copy link
Copy Markdown
Member

LGTM

raymondfeng added a commit that referenced this pull request Dec 12, 2013
@raymondfeng
raymondfeng merged commit 0f4e9e1 into masterDec 12, 2013
@raymondfeng
raymondfeng deleted the feature/access-context branch December 12, 2013 00:26
cfjedimaster pushed a commit to cfjedimaster/loopback that referenced this pull request Feb 20, 2017
@bajtosbajtos mentioned this pull request Feb 21, 2017
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@raymondfeng@slnode@ritch