Skip to content

Globalize - #121

Closed
Setogit wants to merge 7 commits into
masterfrom
globalize
Closed

Globalize#121
Setogit wants to merge 7 commits into
masterfrom
globalize

Conversation

@Setogit

Copy link
Copy Markdown
Contributor

connect to strongloop-internal/scrum-nodeops#1157

Comment threadcommon/models/api.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't make sense to me. This is the documentation string that will show up in the explorer.

  • did you test this works?
  • since almost all the API is defined by JSON files, and they are not translated, won't this be bizarre even if it does work, to have an almost entirely English explorer, with only the remote methods have localized string descriptions?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test passed up to the point master passes locally on my OSX.

strong-mesh-models globalization depends on loopback/explorer globalization strategy which is open at the moment.

@sam-githubsam-github assigned Setogit and unassigned sam-githubJan 14, 2016
@Setogit

Copy link
Copy Markdown
ContributorAuthor

@sl-node test please

Comment threadbin/sl-meshadm.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--help needs protection from translation

@SetogitSetogit assigned sam-github and unassigned SetogitJan 25, 2016
@Setogit

Copy link
Copy Markdown
ContributorAuthor

@sl-node test please

@Setogit

Copy link
Copy Markdown
ContributorAuthor

All windows builds failed. The other builds succeeded.

@Setogit
Setogitforce-pushed the globalize branch 2 times, most recently from be4eaba to 0c165f0CompareJanuary 26, 2016 03:56
@Setogit

Copy link
Copy Markdown
ContributorAuthor

This requires strongloop/strong-globalize#5

@Setogit

Copy link
Copy Markdown
ContributorAuthor

@sl-node test please

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Setogit I don't understand this change.

After globalization, are there no longer quotes around "service 1"?

@sam-githubsam-github assigned Setogit and unassigned sam-githubJan 27, 2016
@SetogitSetogit removed their assignment Jul 5, 2016
@dhmlau

Copy link
Copy Markdown
Member

Closing as abandoned

@dhmlaudhmlau closed this Feb 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Setogit@dhmlau@sam-github