Uh oh!
There was an error while loading. Please reload this page.
Set notebook structure and implemented KTIP algorithm - #1040
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1040 +/- ##
=======================================
Coverage 97.33% 97.33% =======================================
Files 89 89 Lines 15027 15027 =======================================
Hits 14626 14626 Misses 401 401 ☔ View full report in Codecov by Sentry. |
@joehiggi1758 I know that this is still a work-in-progress but this looks fantastic! I haven't gone over things in detail but, at a high level, I really like how you're breaking everything down in consumable chunks and also explaining each part very clearly. One thing I would like to ask is if can please cross-reference sections/figures/algorithms within the paper so something like:
This way, we can quickly find where things are within the original source. Finally, please leave me a comment here when you think it is ready for any type of feedback or if you had any questions. Great job so far! |
joehiggi1758
commented
Nov 14, 2024
@seanlaw hope you're having a great one! I've been fairly busy with work lately, but still wanted to move this forward! I'm about 85% there, the full MOMP implementation isn't working yet - but open to your feedback up to this point on the structure, breakdown and implementation of each sub function! |
seanlaw
commented
Nov 15, 2024
Thanks @joehiggi1758 and no problem on any delays. Please allow me some time to review it and provide feedback. |
0f2766c to
9616686Compareseanlaw
commented
Nov 17, 2024
Moved to #1046 |
Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black(i.e.,python -m pip install blackorconda install -c conda-forge black)flake8(i.e.,python -m pip install flake8orconda install -c conda-forge flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install -c conda-forge pytest-cov)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./in the root stumpy directoryflake8 --extend-exclude=.venv ./in the root stumpy directory./setup.sh dev && ./test.shin the root stumpy directory