Uh oh!
There was an error while loading. Please reload this page.
Fixed #1123 Add missing Returns section in docstrings - #1124
Conversation
Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1124 |
@NimaSarajpoor I don't think I've covered all Please review at your earliest convenience. |
NimaSarajpoor
left a comment
There was a problem hiding this comment.
@seanlaw
Thanks for the PR!! I left two comments. Not relevant directly to this PR but they are related to docstring.py.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
NimaSarajpoor
left a comment
There was a problem hiding this comment.
@seanlaw
I checked other changed files, and left a few comments to bring your attention to the docstrings that have out1 or out2 as the output variable name (and not out).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
seanlaw
commented
Jan 28, 2026
@NimaSarajpoor I think we might be good now? |
Uh oh!
There was an error while loading. Please reload this page.
@seanlaw Nothing stands out to me! I think it is ready to be merged. Thanks for the fix!! |
Uh oh!
There was an error while loading. Please reload this page.
See #1123
Pull Request Checklist
Below is a simple checklist but please do not hesitate to ask for assistance!
black(i.e.,python -m pip install blackorconda install -c conda-forge black)flake8(i.e.,python -m pip install flake8orconda install -c conda-forge flake8)pytest-cov(i.e.,python -m pip install pytest-covorconda install -c conda-forge pytest-cov)black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./in the root stumpy directoryflake8 --extend-exclude=.venv ./in the root stumpy directory./setup.sh dev && ./test.shin the root stumpy directory