Skip to content

Add new sdp functions - #1128

Merged
NimaSarajpoor merged 11 commits into
stumpy-dev:mainfrom
NimaSarajpoor:add-sdp-methods
Feb 13, 2026
Merged

Add new sdp functions#1128
NimaSarajpoor merged 11 commits into
stumpy-dev:mainfrom
NimaSarajpoor:add-sdp-methods

Conversation

@NimaSarajpoor

Copy link
Copy Markdown
Collaborator

This is to address PR 2 described in #1118 (comment). Have copied the corresponding notes below:

  1. Add each new (simple) def _X_sliding_dot_product to sdp.py (i.e., _convolve_sliding_dot_product, _oaconvolve_sliding_dot_product, _pocketfft_sliding_dot_product
  2. Add unit tests that demonstrate that each _X_sliding_dot_product matches the results of naive_rolling_window_dot_product

@gitnotebooks

Copy link
Copy Markdown

Comment threadtests/test_sdp.py Outdated
@NimaSarajpoor

NimaSarajpoor commented Feb 13, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@seanlaw
This is ready for your review. I modified the existing sdp functions in branch main and added the new ones.

@seanlaw

Copy link
Copy Markdown
Contributor

@NimaSarajpoor I think things look good to me!

@NimaSarajpoor
NimaSarajpoor merged commit 2d8854a into stumpy-dev:mainFeb 13, 2026
31 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@NimaSarajpoor@seanlaw