Fixed #1061, Fixed #1080 Failed Snippets Tests

[seanlaw]

• Fixesunit testing failure for snippets #1061
• FixesFixed #1061 failure in snippet unit tests due to the instability of np.sum for array with many small floating point numbers #1080

Pull Request Checklist

Below is a simple checklist but please do not hesitate to ask for assistance!

• Read our Contributing Guide
• Referenced a Github issue (or create one if one doesn't already exist)
• Left a meaningful comment on the original Github issue to discuss the detailed approach for your contribution
• Forked, cloned, and checkedout the newest version of the code
• Created a new branch
• Made necessary code changes
• Installed black (i.e., python -m pip install black or conda install -c conda-forge black)
• Installed flake8 (i.e., python -m pip install flake8 or conda install -c conda-forge flake8)
• Installed pytest-cov (i.e., python -m pip install pytest-cov or conda install -c conda-forge pytest-cov)
• Ran black --exclude=".*\.ipynb" --extend-exclude=".venv" --diff ./ in the root stumpy directory
• Ran flake8 --extend-exclude=.venv ./ in the root stumpy directory
• Ran ./setup.sh dev && ./test.sh in the root stumpy directory

[gitnotebooks]

Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1162

[seanlaw]

Now that we've confirmed that the unit tests are failing as expected, we can now add the code to fix this

[seanlaw]

@NimaSarajpoor Please review at your earliest convenience.

After this, I will make modifications to the tests/test_snippets.py and tests/test_aampdist_snippets.py files to also add a precomputed D (distance profiles) that should help ensure that the precision issue is resolved. Then, this can be merged

[NimaSarajpoor]

Awesome. I've added a couple of comments for your consideration.

[NimaSarajpoor]

Sharing here before I forget: once this is merged, #1080 can be closed.

[seanlaw]

Sharing here before I forget: once this is merged, #1080 can be closed.

I added the failing unit tests (found in those comments) to this PR

[seanlaw]

Alright @NimaSarajpoor, I'm pretty happy with this PR. However, in an abundance of caution I'm actually going to leave this PR open until we encounter three (3) more of the same snippets errors (the main branch doesn't have this fix yet so we should continue to see ocassional failed snippets tests). Then, one-by-one, I will add them to the unit tests here to see if they are fixed by our PR. If so, then I will merge it.

3 Failing Test Cases:

• STUMPY_SEED=1913968968 NUMBA_DISABLE_JIT=1 NUMBA_ENABLE_CUDASIM=1 pixi run ./test.sh custom 1 tests/test_snippets.py
• STUMPY_STATE=<state>
• STUMPY_STATE=<state>

[seanlaw]

Oops, I didn't realize that deleting the forked repo would close this PR :(

[NimaSarajpoor]

@seanlaw

Oops, I didn't realize that deleting the forked repo would close this PR :(

Apparently it is possible to recover. Although I assume you already did the research, I've shared the link below:

https://stackoverflow.com/questions/56411209/how-could-i-recover-deleted-forked-branch-for-pull-request