Fixes for compare/pr page. - #166
Merged
Merged
Conversation
- compare-diff-view: reset visibleCount to INITIAL on new comparison (files identity, not length) - compare-header: "·" separator only when both ahead and behind segments render - compare-page: distinguish pending state from null comparison; render "Nothing to compare" empty state; broaden invalidate predicate to concrete segments (pulls, overview, recentPushableBranch, branchComparison, compareDetail); surface follow-up warnings via toast - compare-sidebar: PickerTrigger is now forwardRef with required label prop; removed <span> wrappers around PopoverTrigger asChild so radix attaches directly to the button - branch-comparison-banner: same-branch early return before pending skeleton - github.functions (createPullRequest): preserve installUrl in catch; collect Promise.allSettled rejections and return them as optional `warnings` on success instead of silently succeeding - github.functions (getRecentPushableBranch): use user-scoped context for getViewer() and listActivities to avoid installation-token failures - github.functions (getCompareDetail): paginate commits up to 3×100; surface files truncation (300-cap) via filesTruncated; switched to getOrRevalidateGitHubResource and bumped resource id to v2; CompareDiffView renders a yellow notice on truncation
Contributor
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughChanges introduce file truncation tracking in PR comparisons, enhanced error handling for PR creation with warning notifications, improved branch comparison logic, and refactored sidebar picker components. A new cached compare resource fetches commits across multiple pages while tracking file count against a cap. The diff view, header, and page components updated to display truncation indicators and handle warnings from PR creation. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant CompareUI as Compare Page UI
participant APILayer as GitHub API Layer
participant GitHub as GitHub GraphQL
User->>CompareUI: Trigger comparison fetch
CompareUI->>APILayer: Call getCompareDetail()
activate APILayer
APILayer->>GitHub: Query commits (page 1)
GitHub-->>APILayer: Return commits + files (max 300)
APILayer->>APILayer: Collect files from page 1
loop Fetch remaining pages (up to max)
APILayer->>GitHub: Query commits (page N)
GitHub-->>APILayer: Return commits
APILayer->>APILayer: Skip files, only collect commits
end
APILayer->>APILayer: Compute filesTruncated (files > cap)
APILayer-->>CompareUI: Return { commits, files, filesTruncated }
deactivate APILayer
CompareUI->>CompareUI: Render diff view with filesTruncated
alt filesTruncated is true
CompareUI->>User: Display warning: "More files than shown"
end
sequenceDiagram
actor User
participant CompareUI as Compare Page UI
participant APILayer as GitHub API Layer
participant GitHub as GitHub GraphQL
User->>CompareUI: Submit create PR form
CompareUI->>APILayer: Call createPullRequest()
activate APILayer
APILayer->>GitHub: Create pull request
GitHub-->>APILayer: Return { pullNumber }
par Parallel follow-up mutations
APILayer->>GitHub: Add labels
APILayer->>GitHub: Add assignees
APILayer->>GitHub: Add reviewers
end
GitHub-->>APILayer: Results via Promise.allSettled
APILayer->>APILayer: Inspect results, collect failures as warnings
alt Any mutation failed
APILayer-->>CompareUI: Return { ok: true, pullNumber, warnings }
else All succeeded
APILayer-->>CompareUI: Return { ok: true, pullNumber }
end
deactivate APILayer
CompareUI->>CompareUI: Invalidate query caches
alt warnings exist
CompareUI->>User: Display toast with warnings
end
CompareUI->>User: Navigate to PR
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
address issues raised by coderabbit
Summary by CodeRabbit
New Features
Bug Fixes
Improvements