Uh oh!
There was an error while loading. Please reload this page.
Aachen Turbine Tutorial - #56
Conversation
alecappiello
commented
Dec 17, 2024
@joshkellyjak, could you review this PR? |
alecappiello
commented
Jan 15, 2025
Hey Josh, could you have a look at this, so that we can finally close it? |
pcarruscag
left a comment
There was a problem hiding this comment.
Is this a copy of the test in TestCases?
alecappiello
commented
Jan 16, 2025
Hi Pedro, the mesh is the same |
pcarruscag
commented
Jan 16, 2025
Then can we put this case in the tutorials.py regression and remove the one from TestCases? |
joshkellyjak
left a comment
There was a problem hiding this comment.
Agree that this should be run as a regression test also
Uh oh!
There was an error while loading. Please reload this page.
| VISCOSITY_MODEL= SUTHERLAND | ||
| % | ||
| % Molecular Viscosity that would be constant (1.716E-5 by default) | ||
| MU_CONSTANT= 1.716E-5 |
There was a problem hiding this comment.
I don't think this does anything so maybe best to remove it to avoid confusing between this and MU_REF
There was a problem hiding this comment.
Considering that it works, I would avoid keep changing, just not to find out later that we missed something, as happened for the entropy fix in combination with JST.
Uh oh!
There was an error while loading. Please reload this page.
| % | ||
| JST_SENSOR_COEFF= ( 0.5, 0.25 ) | ||
| % Spatial numerical order integration | ||
| MUSCL_FLOW= NO |
There was a problem hiding this comment.
I would remove this option too
There was a problem hiding this comment.
I would prefer keeping it, so that new users become aware of it.
Uh oh!
There was an error while loading. Please reload this page.
alecappiello
commented
Feb 7, 2025
Do you mean using this mesh in the tutorial files also for the regression test? If so, this change should not affect this PR. In case, could you guys give the final approve for this PR? |
pcarruscag
commented
Feb 7, 2025
Everything we put in tutorials must have a regression test in tutorials.py, no test, no approval. |
config and mesh files for the Aachen Turbine tutorial